Specify Body locking with ExclusiveStreamReader. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tyoshino Can you take a look at this PR? |
| Each [chunk] (https://streams.spec.whatwg.org/#model) in an associated readable stream must be an ArrayBuffer. | ||
|
|
||
| The body attribute's getter must return the associated readable stream. | ||
| The __bodyUsed__ attribute's getter must return true if one of the following meets and false otherwise. |
There was a problem hiding this comment.
meet -> is met
or
is satisfied
9166fb4 to
55d1154
Compare
d61d9a4 to
8992cf2
Compare
|
@tyoshino, I updated the PR to reflect recent ReadablStream API changes. PTAL. |
| 1. Return _stream_. | ||
|
|
||
| To construct a fixed ReadableStream with given _bytes_, run these steps. | ||
| To construct a fixed ReadableByteStream with given _chunks_, run these steps. |
There was a problem hiding this comment.
how about emphasizing the term we're defining here using bold?
ebd35e5 to
fe41eb9
Compare
| 1. A new step is added after Step 21. | ||
| - Otherwise, set _r_'s readable stream to the result of constructing a fixed ReadableStream with empty bytes. Rethrow any exceptions. | ||
| 1. Step 2 is modified as follows. | ||
| - If _input_ is a Request object and input's body is non-null, run these substeps: |
ba3ce38 to
a7dab8c
Compare
|
lgtm a7dab8c |
|
Thanks! |
This change also reflects recent Streams API changes.
a7dab8c to
af2a0a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 'passed flag' instead of 'used flag' as discussed
at w3c/ServiceWorker#452.