This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Update lessons #30
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,7 +64,7 @@ public class Hello { | |
| } | ||
|
|
||
| private void sayHello(String helloTo) { | ||
| Span span = tracer.buildSpan("say-hello").start(); | ||
|
|
||
| String helloStr = String.format("Hello, %s!", helloTo); | ||
| System.out.println(helloStr); | ||
|
|
@@ -85,7 +85,7 @@ public class Hello { | |
| We are using the following basic features of the OpenTracing API: | ||
| * a `tracer` instance is used to create a span builder via `buildSpan()` | ||
| * each `span` is given an _operation name_, `"say-hello"` in this case | ||
| * builder is used to create a span via `start()` | ||
| * each `span` must be finished by calling its `finish()` function | ||
| * the start and end timestamps of the span will be captured automatically by the tracer implementation | ||
|
|
||
|
|
@@ -94,40 +94,41 @@ That's because the function `GlobalTracer.get()` returns a no-op tracer by defau | |
|
|
||
| ### Initialize a real tracer | ||
|
|
||
| Let's create an instance of a real tracer, such as Jaeger (https://github.com/jaegertracing/jaeger-client-java). | ||
| Our `pom.xml` already imports Jaeger: | ||
|
|
||
| ```xml | ||
| <dependency> | ||
| <groupId>io.jaegertracing</groupId> | ||
| <artifactId>jaeger-core</artifactId> | ||
| <version>0.31.0</version> | ||
| </dependency> | ||
| ``` | ||
|
|
||
| First let's define a helper function that will create a tracer. | ||
|
|
||
| ```java | ||
| import io.jaegertracing.Configuration; | ||
| import io.jaegertracing.Configuration.ReporterConfiguration; | ||
| import io.jaegertracing.Configuration.SamplerConfiguration; | ||
| import io.jaegertracing.internal.JaegerTracer; | ||
|
|
||
| public static JaegerTracer initTracer(String service) { | ||
| SamplerConfiguration samplerConfig = new SamplerConfiguration().withType("const").withParam(1); | ||
|
There was a problem hiding this comment. How about we use a simple There was a problem hiding this comment. @jpkrohling, I just started learning OpenTracing, so I'm not familiar with "export the relevant env vars", yet. There was a problem hiding this comment. Fair enough. This is particular to Jaeger (not generic OpenTracing), and it might indeed confuse users. For reference, I'm talking about There was a problem hiding this comment. Could you change this to use |
||
| ReporterConfiguration reporterConfig = new ReporterConfiguration().withLogSpans(true); | ||
| Configuration config = new Configuration(service).withSampler(samplerConfig).withReporter(reporterConfig); | ||
| return config.getTracer(); | ||
| } | ||
| ``` | ||
|
|
||
| To use this instance, let's change the main function: | ||
|
|
||
| ```java | ||
| import io.jaegertracing.internal.JaegerTracer; | ||
|
|
||
| try (JaegerTracer tracer = initTracer("hello-world")) { | ||
| new Hello(tracer).sayHello(helloTo); | ||
| } | ||
| ``` | ||
|
|
||
| Note that we are passing a string `hello-world` to the init method. It is used to mark all spans emitted by | ||
|
|
@@ -137,9 +138,9 @@ If we run the program now, we should see a span logged: | |
|
|
||
| ``` | ||
| $ ./run.sh lesson01.exercise.Hello Bryan | ||
| [lesson01.exercise.Hello.main()] INFO io.jaegertracing.Configuration - Initialized tracer=Tracer(...) | ||
| Hello, Bryan! | ||
| [lesson01.exercise.Hello.main()] INFO io.jaegertracing.reporters.LoggingReporter - Span reported: 76509ca0cd333055:76509ca0cd333055:0:1 - say-hello | ||
| ``` | ||
|
|
||
| If you have Jaeger backend running, you should be able to see the trace in the UI. | ||
|
|
@@ -177,7 +178,7 @@ In the case of `Hello Bryan`, the string `"Bryan"` is a good candidate for a spa | |
| to the whole span and not to a particular moment in time. We can record it like this: | ||
|
|
||
| ```java | ||
| Span span = tracer.buildSpan("say-hello").start(); | ||
| span.setTag("hello-to", helloTo); | ||
| ``` | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,23 @@ | ||
| package lesson01.solution; | ||
|
|
||
| import com.google.common.collect.ImmutableMap; | ||
|
|
||
| import io.jaegertracing.internal.JaegerTracer; | ||
| import io.opentracing.Span; | ||
| import lib.Tracing; | ||
|
|
||
| public class Hello { | ||
|
|
||
| private final JaegerTracer tracer; | ||
|
|
||
| private Hello(JaegerTracer tracer) { | ||
| this.tracer = tracer; | ||
| } | ||
|
|
||
| private void sayHello(String helloTo) { | ||
| Span span = tracer.buildSpan("say-hello").start(); | ||
| span.setTag("hello-to", helloTo); | ||
|
|
||
| String helloStr = String.format("Hello, %s!", helloTo); | ||
| span.log(ImmutableMap.of("event", "string-format", "value", helloStr)); | ||
|
|
||
|
|
@@ -32,8 +32,8 @@ public static void main(String[] args) { | |
| throw new IllegalArgumentException("Expecting one argument"); | ||
| } | ||
| String helloTo = args[0]; | ||
| try (JaegerTracer tracer = Tracing.init("hello-world")) { | ||
|
There was a problem hiding this comment. IMO, the tutorial should be using OT's Tracer instead of JaegerTracer as much as possible. The side effect is that, at least for now, we'd need to close the tracer manually (see jaegertracing/jaeger-client-java#544). There was a problem hiding this comment. That said, we could change the tutorial later, once we fix the mentioned issue. There was a problem hiding this comment. I absolutely agree! I have changed the code and lesson01/README.md to reflect this. |
||
| new Hello(tracer).sayHello(helloTo); | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,14 @@ | ||
| package lesson02.solution; | ||
|
|
||
| import com.google.common.collect.ImmutableMap; | ||
|
|
||
| import io.jaegertracing.internal.JaegerTracer; | ||
| import io.opentracing.Scope; | ||
| import io.opentracing.Tracer; | ||
| import lib.Tracing; | ||
|
|
||
| public class HelloActive { | ||
|
|
||
| private final Tracer tracer; | ||
|
|
||
| private HelloActive(Tracer tracer) { | ||
|
|
@@ -17,7 +18,7 @@ private HelloActive(Tracer tracer) { | |
| private void sayHello(String helloTo) { | ||
| try (Scope scope = tracer.buildSpan("say-hello").startActive(true)) { | ||
| scope.span().setTag("hello-to", helloTo); | ||
|
|
||
| String helloStr = formatString(helloTo); | ||
| printHello(helloStr); | ||
| } | ||
|
|
@@ -45,6 +46,5 @@ public static void main(String[] args) { | |
| String helloTo = args[0]; | ||
| Tracer tracer = Tracing.init("hello-world"); | ||
| new HelloActive(tracer).sayHello(helloTo); | ||
|
There was a problem hiding this comment. You'll still need this until we release 0.31.1, which includes the JVM shutdown hook. There was a problem hiding this comment. I have been waiting for opentracing/opentracing-java#250 and opentracing/specification#128 to move forward with the Closeable spec, but it seems this will take a while. I've updated this pull request to upcast to JaegerTracer in a try-resource block. |
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.32.0, otherwise, you'll need to add the
#close()calls. The 0.32.0 implements the "close on JVM shutdown" feature.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavolloffay, is 0.32.0 available on maven central already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be, if it's not I don't want to redo the release 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's there, just confirmed :)