forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Security Solution] Fixes mis-alignment in the labels of Filter contr…
…ols on Alerts Page. (elastic#192094) ## Summary As stated in elastic#192092 , the labels of filter controls were mis-aligned. This was due to some changes in EUI were conflicting with our custom styling. This PR removes the custom styling. ### Before  ### Issues with Error state It looks like recent PR elastic#190636 on 03-Sept made the controls compact but the error state was left out. This PR fixes that. I would request @elastic/kibana-presentation team to review it once. <img width="1920" alt="grafik" src="https://github.com/user-attachments/assets/4025c79f-2602-4221-a136-436b6759096f"> ### After Below video shows fixes in success, loading and error states. @elastic/response-ops team, Could you please check in other areas as well where these filters are used. Thanks. https://github.com/user-attachments/assets/7e0f6035-171c-4a4b-99c6-116ad577a019
- Loading branch information
Showing
4 changed files
with
5 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
src/plugins/embeddable/public/lib/embeddables/error_embeddable.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters