-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle highlight with mouse events only #331
Conversation
pinging @yuku for visibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR has broken the fix for #323. If you look at the behavior of GitHub's Mention input, for example, the behavior in v0.1.6 is more natural. |
What do you think about the above behavior? |
Because of my lack of interest on the project, I'd approved this PR by just watching the fancy gif in the PR description. Now I had closer look at the patch and found some issues in that. (For example, I'd like to avoid using So I'm going to revert this PR. Sorry for my inconsistency. |
Thanks! 🙏 |
Goal:
The goal of this PR is to use javascript mouse events to highlight active elements in the emoji dropdown.
Summary:
Right now, the first item of the emoji dropdown stays highlighted even when selecting other elements. The reason for that is that the current logic does not deactivate the first element when the dropdown is first shown. This PR deactivates all elements on every mouse movement.