Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra_test.go: Add test timeout multiplier environment variable #337

Merged
merged 1 commit into from
May 30, 2023

Conversation

piggynl
Copy link
Contributor

@piggynl piggynl commented Nov 11, 2022

Hi,

Currently some performance tests in extra_test.go are failing in low-performance environments (QEMU user mode emulation in my case).

=== RUN   TestDeepNestedLabelPerformance
    extra_test.go:112: Parsing deep nested labels took more 5 secs
--- FAIL: TestDeepNestedLabelPerformance (25.33s)
=== RUN   TestManyProcessingInstructionPerformance
    extra_test.go:132: Parsing processing instructions took more 5 secs
--- FAIL: TestManyProcessingInstructionPerformance (14.11s)
=== RUN   TestManyCDATAPerformance
    extra_test.go:152: Parsing processing instructions took more 5 secs
--- FAIL: TestManyCDATAPerformance (33.70s)
=== RUN   TestManyDeclPerformance
    extra_test.go:172: Parsing processing instructions took more 5 secs
--- FAIL: TestManyDeclPerformance (16.28s)
=== RUN   TestManyCommentPerformance
    extra_test.go:192: Parsing processing instructions took more 5 secs
--- FAIL: TestManyCommentPerformance (40.88s)

I think reading a timeout multiplier from environment variable is a reasonable way to test goldmark in those low-performance environments without affecting the tests in normal environments.

Thank you for looking into this PR!

@stale
Copy link

stale bot commented Jan 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 7, 2023
@stale stale bot closed this May 21, 2023
@yuin yuin reopened this May 30, 2023
@yuin yuin merged commit 4536092 into yuin:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants