Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ticket# 2528732 #48

Closed
wants to merge 3 commits into from
Closed

Fix for ticket# 2528732 #48

wants to merge 3 commits into from

Conversation

redbat
Copy link
Contributor

@redbat redbat commented Nov 14, 2011

attribute is set to default value if setter returned invalid value and it was being initialized.

@ericf
Copy link
Member

ericf commented Nov 14, 2011

@sdesai this one is for you.

@redbat
Copy link
Contributor Author

redbat commented Nov 15, 2011

np, killing free time ;).

  • yep, that is taken care of in the previous block, when there exist a validator but the value is not valid, it is set to default. We can optimize it a bit, i.e. call state.get(attrName, DEF_VALUE) only once.
    but then again, two calls to it would happen only once, during initializing;
    think worth changing it ?

@sdesai
Copy link
Contributor

sdesai commented Nov 15, 2011

No, I think that's fine. I'll review it and pull it in. Thanks again.

@ghost ghost assigned sdesai Jan 30, 2012
@hojberg
Copy link
Contributor

hojberg commented Aug 21, 2012

any update on this?

@sdesai
Copy link
Contributor

sdesai commented Aug 21, 2012

It's on my plate. I haven't had a chance to review and pull it in. I can bump it up in priority

@sdesai
Copy link
Contributor

sdesai commented Sep 20, 2012

I'll be putting this in the next sprint backlog starting 9/25/12

@ghost ghost assigned ericf Oct 25, 2012
</html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline.

@ericf
Copy link
Member

ericf commented Jan 3, 2013

Closing this pull request in favor of an updated version of this change: #387

@ericf ericf closed this Jan 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants