Add a provision in driver to try another server on login timeout #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashetkar
approved these changes
Jun 7, 2024
| @@ -110,8 +110,9 @@ public synchronized String getLeastLoadedServer(List<String> failedHosts) { | |||
| int min = Integer.MAX_VALUE; | |||
| ArrayList<String> minConnectionsHostList = new ArrayList<>(); | |||
| for (String h : hostToNumConnMap.keySet()) { | |||
| if (failedHosts.contains(h)) { | |||
| LOGGER.fine("Skipping failed host " + h); | |||
| boolean wasTimedOutHost = timedOutHosts != null && timedOutHosts.contains(h) ? true : false; | |||
There was a problem hiding this comment.
nit
Suggested change
| boolean wasTimedOutHost = timedOutHosts != null && timedOutHosts.contains(h) ? true : false; | |
| boolean wasTimedOutHost = timedOutHosts != null && timedOutHosts.contains(h); |
ashetkar
pushed a commit
that referenced
this pull request
Oct 4, 2024
Adds a feature of trying another server when login timeout is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
gh-issue
The driver is being enhanced to handle a connection timing out due to a busy server when login timeout is used by the user.
The timed out server is added to a temporary list which is ignored when the Connect Thread goes for the next attempt after timeout. This feature is enabled only when load-balance is set to true.
Testing:
Manually tested both the scenarios, i.e. directly using login timeout property in url and second by using login timeout property in url and Hikari pool combination.
[ For now I just added temporary code to sleep during connection attempt to mimic an unresponsive server. Removed the test code as it was not standard. We will add a cleaner test hook to simulate this cleanly later ]