[pornhub] Added support for PornHub Premium. #24063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twaddington
commented
Feb 17, 2020
| @@ -3523,7 +3523,7 @@ def str_to_int(int_str): | |||
| if isinstance(int_str, compat_integer_types): | |||
| return int_str | |||
| elif isinstance(int_str, compat_str): | |||
| int_str = re.sub(r'[,\.\+]', '', int_str) | |||
| int_str = re.sub(r'[,\.\s\+]', '', int_str) | |||
There was a problem hiding this comment.
This fixes view count parsing for international sites that use a space separator (e.g. fr.pornhub.com) as seen here:
This change can easily be reverted if it causes problems.
8a526d5 to
a194bcc
Compare
|
If this is too large a change I can work on breaking it down into smaller pull-requests. |
This commit completely refactors the PornHub extractor and adds a new extractor for PornHub Premium. Several minor issues have been fixed with the info extractor and support for international versions of PornHub should be better. Additionally, registered PornHub users can now authenticate and use youtube-dl to archive videos they have purchased. --netrc support has been added for both pornhub and pornhubpremium.
|
Closing as the maintainers are unlikely to ever accept a refactor like this. May try a more surgical implementation to see if I can get it accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Resolves #18797
This commit completely overhauls the PornHub extractor and adds a new
extractor for PornHub Premium. Several minor issues have been fixed with
the info extractor and support for international versions of PornHub
should be better.
Additionally, registered PornHub users can now authenticate and use
youtube-dl to archive videos they have purchased.
--netrc support has been added for both pornhub and pornhubpremium.
For simplicity, Thumbzilla has been split out into it's own extractor.