Add missing blank lines after class or function definition. #10689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does not fix anything. What's the point? |
|
@dstftw pep8 |
|
Latest flake8 has no complaints. |
|
It was proposed by GvR in PyCQA/pycodestyle#400 and later implemented in PyCQA/pycodestyle#536. This check is not included in the latest release of pycodestyle (2.0.0) yet. Personally I prefer to wait for pycodestyle 2.1 before applying this rule in youtube-dl, which should happen soon. |
|
The latest flake8 (3.0.4) was not compatible with pycodestyle 2.1.0 yet (https://gitlab.com/pycqa/flake8/issues/246). The fix is landed in flake8 git-master. Debian has applied the upstream fix, too, while Arch Linux uses a wrong patch (https://bugs.archlinux.org/task/51756). I'll fix it when Arch Linux applies the correct patch. |
yan12125
pushed a commit
that referenced
this pull request
Nov 17, 2016
In pycodestyle 2.1.0, E305 was introduced, which requires two blank lines after top level declarations, too. See PyCQA/pycodestyle#400 See also #10689; thanks @stepshal for first mentioning this issue and initial patches
calbrecht
referenced
this pull request
in calbrecht/youtube-dl
Dec 26, 2016
In pycodestyle 2.1.0, E305 was introduced, which requires two blank lines after top level declarations, too. See PyCQA/pycodestyle#400 See also #10689; thanks @stepshal for first mentioning this issue and initial patches
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
What is the purpose of your pull request?
Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.