-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid leaking -std=gnu++11 flag to user's targets #127
Conversation
Thanks for good advice about private flag with |
@yse sure. however, adding |
9f53280
to
cccfc1b
Compare
set(CMAKE_CXX_STANDARD 11) | ||
set(CMAKE_CXX_STANDARD_REQUIRED ON) | ||
endif () | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yse job is done. This will affect every subdirectories (core, gui, etc) and won't propagate upward for those who are adding easy_profiler as a subdirectory in their project.
endif () | ||
set_target_properties(easy_profiler PROPERTIES CXX_STANDARD 11 CXX_STANDARD_REQUIRED ON) | ||
endif () | ||
endif () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yse no longer needed. Taken care of by the root cmakelists.txt now.
@yse are you okay with my latest change proposal? |
Oh, excuse me, I was very busy in other project and missed some letters. |
This fixes #126