node-transport: document MulticastOptions.group limitation

yoursunny · Dec 24, 2024 · d953fe6 · d953fe6
1 parent 07c589e
commit d953fe6
Show file tree

Hide file tree

Showing 9 changed files with 16 additions and 9 deletions.
diff --git a/integ/browser-tests/package.json b/integ/browser-tests/package.json
@@ -25,8 +25,8 @@
   "devDependencies": {
     "@nodelib/fs.walk": "^3.0.1",
     "@types/webpack": "^5.28.5",
-    "@zenfs/core": "1.6.8",
-    "@zenfs/dom": "1.1.0",
+    "@zenfs/core": "^1.6.16",
+    "@zenfs/dom": "^1.1.0",
     "fork-ts-checker-webpack-plugin": "^9.0.2",
     "html-webpack-plugin": "^5.6.3",
     "puppeteer": "^23.11.1",

diff --git a/package.json b/package.json
@@ -17,7 +17,7 @@
   "devDependencies": {
     "@types/node": "^22.10.2",
     "@types/wtfnode": "^0.7.3",
-    "@typescript/lib-dom": "npm:@types/web@0.0.187",
+    "@typescript/lib-dom": "npm:@types/web@0.0.188",
     "@vitest/coverage-v8": "^2.1.8",
     "@yoursunny/xo-config": "0.60.0",
     "codedown": "^3.2.1",

diff --git a/pkg/fileserver/README.md b/pkg/fileserver/README.md
@@ -16,6 +16,6 @@ Client (consumer):
 
 * simple client
   * demonstrated in `@ndn/cat` package `file-client` subcommand
-* [ZenFS](https://zen-fs.github.io/core/) wrapper
+* [ZenFS](https://zenfs.dev/core/) wrapper
 
 Server (producer): not yet.
diff --git a/pkg/fileserver/package.json b/pkg/fileserver/package.json
@@ -32,7 +32,7 @@
     "@ndn/segmented-object": "workspace:*",
     "@ndn/tlv": "workspace:*",
     "@ndn/util": "workspace:*",
-    "@zenfs/core": "1.6.8",
+    "@zenfs/core": "^1.6.16",
     "mnemonist": "^0.39.8",
     "obliterator": "^2.0.4",
     "streaming-iterables": "^8.0.1",

diff --git a/pkg/l3face/src/l3face.ts b/pkg/l3face/src/l3face.ts
@@ -172,6 +172,9 @@ export class L3Face extends TypedEventTarget<EventMap> implements FwFace.RxTx {
     const txSourceIterable: AsyncIterable<Uint8Array> = {
       [Symbol.asyncIterator]: () => ({
         next: () => txSourceIterator.next(),
+        async [Symbol.asyncDispose]() {
+          // https://github.com/zen-fs/core/issues/158
+        },
       }),
     };
 

diff --git a/pkg/nfdmgmt/src/prefix-reg.ts b/pkg/nfdmgmt/src/prefix-reg.ts
@@ -97,8 +97,6 @@ export class NfdPrefixReg extends ReadvertiseDestination<State> {
 
     using closers = new Closers();
     closers.push(...map(preloadProducers, ([, p]) => p), tapFace);
-    // https://github.com/typescript-eslint/typescript-eslint/issues/7889
-
     return await f({ ...this.commandOptions, cOpts: eOpts });
   }
 

diff --git a/pkg/nfdmgmt/src/status-dataset-nfd.ts b/pkg/nfdmgmt/src/status-dataset-nfd.ts
@@ -28,7 +28,7 @@ const buildGeneralStatus = new StructBuilder("GeneralStatus")
   .add(TT.NSatisfiedInterests, "nSatisfiedInterests", StructFieldNNI, { required: true })
   .add(TT.NUnsatisfiedInterests, "nUnsatisfiedInterests", StructFieldNNI, { required: true })
   .setIsCritical(EvDecoder.neverCritical);
-/** NFD status/general dataset. */
+/** NFD *status/general* dataset. */
 export class GeneralStatus extends buildGeneralStatus.baseClass<GeneralStatus>() {
   public static datasetName = "status/general";
 

diff --git a/pkg/node-transport/src/udp-helper.ts b/pkg/node-transport/src/udp-helper.ts
@@ -105,6 +105,12 @@ export interface MulticastOptions extends SocketBufferOptions {
   /**
    * Multicast group address.
    * @defaultValue 224.0.23.170
+   *
+   * @remarks
+   * Due to dgram.Socket API limitation, if multiple multicast UDP transports are using the same
+   * port number but different group addresses, incoming traffic may be received on all sockets
+   * regardless of the group address. This also affects multicast UDP transports in other programs
+   * such as YaNFD. To isolate the traffic, the port number must be changed.
    */
   group?: string;
 

diff --git a/pkg/segmented-object/package.json b/pkg/segmented-object/package.json
@@ -31,7 +31,7 @@
     "@ndn/naming-convention2": "workspace:*",
     "@ndn/packet": "workspace:*",
     "@ndn/util": "workspace:*",
-    "@zenfs/core": "1.6.8",
+    "@zenfs/core": "^1.6.16",
     "it-keepalive": "^1.2.0",
     "mnemonist": "^0.39.8",
     "obliterator": "^2.0.4",