Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move cookie and gdpr filters to cookie_filters.txt #227

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

RedDragonWebDesign
Copy link
Contributor

Moved cookie and gdpr filters to cookie_filters.txt. Per our discussion in the sublists issue.

Technique: used regex to isolate lines with cookie/gdpr, and regex to isolate non cookie/gdpr lines.

/^.*(cookie|gdpr).*$/gim
/^((?!cookie|gdpr).)*$/gim

Copy link
Owner

@yourduskquibbles yourduskquibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I like your simple regex approach! Thank you!

@yourduskquibbles yourduskquibbles merged commit ace5e1b into yourduskquibbles:master Jun 29, 2020
@yourduskquibbles
Copy link
Owner

Related #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants