Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DARK: Themes > Ignore user created folders inside default theme dirs #68

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

eihabkhan
Copy link
Member

JIRA Ticket

DARK

QA Steps

  • cd into the cli folder.
  • Link the cli package globally pnpm -g link.
  • Go the the /themes repo (Make sure it's cloned).
  • Link the cli package with it.
  • cd into one of the themes (Aura for example).
  • Create a directory inside one of the directories /sections/foo for example.
  • Run pnpm dev.
  • The command should fail with an EISDIR error: illegal operation on a directory, read.
  • Checkout to this PR's branch.
  • run pnpm build.
  • Go back to Aura.
  • run pnpm dev.
  • The command should continue normally.

Note

Leave empty when you have nothing to say

@eihabkhan eihabkhan added the 💻 Ready for review Requires a review from another developer. label Aug 30, 2024
@eihabkhan eihabkhan self-assigned this Aug 30, 2024
@eihabkhan eihabkhan merged commit 565e2dc into main Sep 3, 2024
@eihabkhan eihabkhan deleted the dark-themes-ignore-dirs branch September 3, 2024 09:50
@eihabkhan eihabkhan added ✅ Reviewed PR has been reviewed and approved. and removed 💻 Ready for review Requires a review from another developer. labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants