Revert async loading of main hljs

[gagbo]

Having the main hljs loading asynchronously makes the code blocks bug, since the
page throws hljs is undefined on hljs.initHighlightOnLoad called just after.

[dwy6626]

Just personal opinion. The initHighlightingOnLoad function is deprecated, it may be solved by using highlightAll instead?
https://highlightjs.readthedocs.io/en/latest/api.html#inithighlightingonload

[Tristor]

Howdy, I made the original change. I'd like to understand this better, as I am using syntax highlighting on my site as well and did not encounter any issues with this change. It's possible there could be an underlying race condition I created by making this load async that doesn't trigger for me, but does for you.

The intention is to not have blocking JS in the head. If at all possible, it's best practice for performance to not have blocking JS and to lazy load or asynchronously load JS imports.

[Szeraax]

So wouldn't the PROPER way to get both satisfied for it to wait until the window is loaded before applying the syntax? Something like:

<script defer src='...'></script>
<script defer src='...'></script>
<script defer>window.onload = (event) => { hljs.highlightAll(); }</script>

That's what I'm using and its working GREAT. Tested on firefox, chrome, and edge. Source material: https://flaviocopes.com/javascript-async-defer/

I found that when I used async for the js files and nothing or defer for the window.onload() script, it would sometimes work and sometimes not work. It would seem that if all three of them are set to defer, it will make sure to run them in order after the HTML has run through the parser. Anyone able to confirm if I'm crazy or not? #NotADev

Unrelated, can someone explain to me why the URIs are missing the https: infront of the //.../?