Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating templates to make them more w3c compatible. #103

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

warlord500
Copy link

makes the templates follow the w3c validator more closely at
https://validator.w3.org/#validate_by_input

@Tristor
Copy link
Contributor

Tristor commented Feb 6, 2021

Howdy @warlord500, could you rebase this changeset on current master? It looks like you pulled in some changes from a branch by @tetsuyainfra. As long as it's rebased on top of current master, even if it's not merged into master, other folks can pull your changes into their forks. I'd be interested in using this to improve HTML output validity.

Let me know if you'd like an assist, and I'll do what I can.

@Tristor
Copy link
Contributor

Tristor commented Feb 8, 2021

In reviewing your changes on a local branch, I'm not sure how this changes compatibility other than the removal of the role attribute. Can you expand on this? It looks like there's some other unrelated changes here that add additional functionality that should be split into a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants