Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SignedURLOptions.start_time #246

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

cpick
Copy link
Contributor

@cpick cpick commented Mar 26, 2024

Allow the caller of Client.signed_url() to specify the time from which the URL will be valid. This allows signing URLs for future use.

Allow the caller of `Client.signed_url()` to specify the time from which
the URL will be valid.  This allows signing URLs for future use.
@cpick cpick force-pushed the signed-url-options-start-time branch from ef77720 to f85780a Compare March 28, 2024 02:52
@yoshidan yoshidan added the safe to test safe to test label Apr 5, 2024
@yoshidan
Copy link
Owner

yoshidan commented Apr 9, 2024

@cpick Thanks for your PR. cloud you run cargo clippy --fix to fix CI error.

@cpick
Copy link
Contributor Author

cpick commented Apr 10, 2024

@yoshidan

@cpick Thanks for your PR. cloud you run cargo clippy --fix to fix CI error.

Done!

@yoshidan yoshidan added safe to test safe to test and removed safe to test safe to test labels Apr 11, 2024
@yoshidan yoshidan merged commit e789b5b into yoshidan:main Apr 12, 2024
6 checks passed
@cpick cpick deleted the signed-url-options-start-time branch April 17, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test safe to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants