Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Concurrency Tests between Array Operations #985

Merged
merged 12 commits into from
Sep 2, 2024
Prev Previous commit
Next Next commit
Fix lint error
  • Loading branch information
cloneot committed Aug 29, 2024
commit 8f5ea937f3c9e5453eaba7837c9f98777246496e
11 changes: 6 additions & 5 deletions pkg/document/json/array.go
Original file line number Diff line number Diff line change
Expand Up @@ -433,14 +433,15 @@ func (p *Array) setByIndexInternal(
ticket,
))

removed, err := p.SetByIndex(createdAt, value, ticket)
_, err = p.SetByIndex(createdAt, value, ticket)
// removed, err := p.SetByIndex(createdAt, value, ticket)
if err != nil {
panic(err)
}
if removed != nil {
// TODO(junseo): add GC-like logic
// p.context.RegisterRemovedElementPair(p, removed)
}
// if removed != nil {
// // TODO(junseo): add GC-like logic
// // p.context.RegisterRemovedElementPair(p, removed)
// }
p.context.RegisterElement(value)
return elem
}
Expand Down
11 changes: 6 additions & 5 deletions pkg/document/operations/set_by_index.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,16 @@ func (o *SetByIndex) Execute(root *crdt.Root) error {
return err
}

removed, err := obj.SetByIndex(o.createdAt, value, o.executedAt)
_, err = obj.SetByIndex(o.createdAt, value, o.executedAt)
// removed, err := obj.SetByIndex(o.createdAt, value, o.executedAt)
if err != nil {
return err
}

if removed != nil {
// TODO(junseo): add GC-like logic
// root.RegisterRemovedElementPair(obj, removed)
}
// if removed != nil {
// // TODO(junseo): add GC-like logic
// // root.RegisterRemovedElementPair(obj, removed)
// }
root.RegisterElement(value)
return nil
}
Expand Down
Loading