Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch latest snapshot metadata to determine snapshot creation need #597

Merged
merged 18 commits into from
Aug 7, 2023

Conversation

hyemmie
Copy link
Contributor

@hyemmie hyemmie commented Aug 3, 2023

What this PR does / why we need it:
To reduce unnecessary data I/O between DB and server, added repository function which only fetches snapshot's metadata.

Which issue(s) this PR fixes:

Fixes #387

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation:

Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@CLAassistant
Copy link

CLAassistant commented Aug 3, 2023

CLA assistant check
All committers have signed the CLA.

@hyemmie hyemmie marked this pull request as draft August 3, 2023 10:14
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #597 (b44995b) into main (7f39f2f) will decrease coverage by 0.20%.
The diff coverage is 26.08%.

@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   51.45%   51.26%   -0.20%     
==========================================
  Files          66       67       +1     
  Lines        6977     7019      +42     
==========================================
+ Hits         3590     3598       +8     
- Misses       2911     2944      +33     
- Partials      476      477       +1     
Files Changed Coverage Δ
server/backend/database/snapshot_info.go 0.00% <0.00%> (ø)
server/backend/database/mongo/client.go 38.65% <19.04%> (-0.76%) ⬇️
server/backend/database/memory/database.go 53.00% <50.00%> (-0.14%) ⬇️

@hackerwins hackerwins marked this pull request as ready for review August 6, 2023 11:23
@hackerwins hackerwins requested a review from krapie August 6, 2023 11:23
@hackerwins hackerwins added the cleanup 🧹 Paying off technical debt label Aug 6, 2023
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins changed the title Fetching metadata Fetch latest snapshot metadata to determine snapshot creation need Aug 7, 2023
@hackerwins hackerwins merged commit 12403da into yorkie-team:main Aug 7, 2023
Wu22e pushed a commit to Wu22e/yorkie that referenced this pull request Sep 3, 2023
…orkie-team#597)

To reduce unnecessary data I/O between DB and server, added repository
function which only fetches snapshot's metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 Paying off technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce repository method for only fetching SnapshotInfo's metadata
3 participants