-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch latest snapshot metadata to determine snapshot creation need #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #597 +/- ##
==========================================
- Coverage 51.45% 51.26% -0.20%
==========================================
Files 66 67 +1
Lines 6977 7019 +42
==========================================
+ Hits 3590 3598 +8
- Misses 2911 2944 +33
- Partials 476 477 +1
|
hackerwins
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
hackerwins
changed the title
Fetching metadata
Fetch latest snapshot metadata to determine snapshot creation need
Aug 7, 2023
Wu22e
pushed a commit
to Wu22e/yorkie
that referenced
this pull request
Sep 3, 2023
…orkie-team#597) To reduce unnecessary data I/O between DB and server, added repository function which only fetches snapshot's metadata.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To reduce unnecessary data I/O between DB and server, added repository function which only fetches snapshot's metadata.
Which issue(s) this PR fixes:
Fixes #387
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: