Update piwigo-nginx-site #18
Conversation
Use search-terminating prefix location matching, i.e. "^~", for the "internal" directories, to make these blocks more robust against additional regular expression location blocks which may be added. Add 3 work-arounds for the extra security blocks.
There was a problem hiding this comment.
Hi @philtuckey
Thank you for this changes.
just a few minor changes
| # Enable the letsencrypt "webroot installation" verification step | ||
| # as used for example by the openmediavault letsencrypt plugin | ||
| location ^~ /.well-known/acme-challenge { |
There was a problem hiding this comment.
I think including letsencrypt block is out of scope for this file.
We want to keep it relevant to the piwigo plugin.
| # Enable the "Display reference file" link of the LocalFiles Editor plugin | ||
| location = /plugins/LocalFilesEditor/show_default.php { | ||
| try_files $uri =404; |
There was a problem hiding this comment.
I think this should probably come after the location = /plugins/piwigo_privacy/get.php block
Also better to give generic explanation that if you use the security block this is how you can open other php routes but leave the actual block commented out.
This is also apply for the metadata block. I don't think we need a block for each file
But just give the tools folder as another location with files that are worth considering
|
What is blocking the merge/finishing here? |
See comments above |
|
Hi. 2 years ago I figured out how to do a change request, I think because I was asked to at the time. I haven't gone any further on guthub since and have probably forgotten whatever I knew at the time. If I understand correctly I am somehow blocking a process here. Please tell me the simplest thing I can do to unblock it, maybe cancelling the request somehow? Best regards |
Hi @philtuckey. It's really up to you if you want it merged or not. Not sure why @Catfriend1 need this getting merged as this PR is mostly documentation change that doesn't really affect the plugin behaviour. @Catfriend1 if you need this changes for any specific reason you can work on this PR so it'll be ok to merge |
Use search-terminating prefix location matching, i.e. "^~", for the "internal" directories, to make these blocks more robust against additional regular expression location blocks which may be added.
Add 3 work-arounds for the extra security blocks.