Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana dashboard ds selector and repeat kinds #135

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

northys
Copy link
Contributor

@northys northys commented Nov 9, 2023

I wanted to do at least some contribution to this brilliant exporter and I'm good at Grafana so:

  • I've updated dashboard to use datasource selector - helpful when you have one grafana with access to multiple prometheus instances
  • I've updated the bottom pannels to repeating so you don't have to update the dashboard each time new Kind is exported / supported by kor.
  • I did some manual cleanup in the exported dashboard because the oficial Dashboard export option via share placed some internal IDs of our instance
  • I don't have grafana with kor datasource without sensitive information so I can't update the image :(

Sadly I have grafana 10 so please try if you can import it to your grafana 9 (maybe with the requires change back to 9.4.3 I don't see much special about my changes so it must work)

Data source selector
image

Repeat by variable + variable $kind in query
image

Copy link
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonahd yonahd merged commit cf6858b into yonahd:main Nov 9, 2023
@yonahd
Copy link
Owner

yonahd commented Nov 9, 2023

Thanks for the contribution!
BTW, I would love to hear about your experience with Kor.
If it has been able to help with decluttering your cluster etc...

If this is a possibility, how can I reach out?

@northys northys deleted the grafana_dashboard_update branch November 9, 2023 16:43
@northys
Copy link
Contributor Author

northys commented Nov 9, 2023

Added you on linkedin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants