Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exposing angles #94

Merged
merged 1 commit into from
Apr 6, 2020
Merged

exposing angles #94

merged 1 commit into from
Apr 6, 2020

Conversation

yomotsu
Copy link
Owner

@yomotsu yomotsu commented Apr 5, 2020

see #93

@yomotsu yomotsu mentioned this pull request Apr 5, 2020
Closed
@paulmelnikow
Copy link
Contributor

Yea! Are these always set? Do they need to be added to the types?

@yomotsu
Copy link
Owner Author

yomotsu commented Apr 6, 2020

Yea! Are these always set?

Since it's just a getter, you can get the value whenever👍

Do they need to be added to the types?

Do you mean d.ts? the d.ts is generated automatically.

@paulmelnikow
Copy link
Contributor

Gotcha. Yea, this looks great!

@yomotsu
Copy link
Owner Author

yomotsu commented Apr 6, 2020

Thanks for reviewing.
I will publish the next update this weekend, but if you need this asap, let me know.

@yomotsu yomotsu merged commit 7447da9 into dev Apr 6, 2020
@paulmelnikow
Copy link
Contributor

I'm grabbing _spherical for the moment though I'd be happy to update it once this is merged.

@yomotsu yomotsu deleted the feature/exposing-angles branch April 6, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmelnikow paulmelnikow paulmelnikow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yomotsu @paulmelnikow