feat: make fitToBox() abort itself when it is given an empty box
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b5vr
commented
Oct 9, 2020
Comment on lines
+979
to
+980
| console.warn( 'camera-controls: fitTo() cannot be used with an empty box. Aborting' ); | ||
| return; |
There was a problem hiding this comment.
I chose warn + early abort. Does it look good for you?
|
Thanks for your investigation.
That's a good point. Now that I think of it, it could happen with default |
|
merged! thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems doing
fitToBoxagainst empty boxes completely messes its internal state up sincev1.20.x.First of all I don't think people wants to do
fitToBoxagainst empty boxes.