Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

focal offset should take z-offset for PerspectiveCamera #136

Merged
merged 1 commit into from
Sep 23, 2020
Merged

focal offset should take z-offset for PerspectiveCamera #136

merged 1 commit into from
Sep 23, 2020

Conversation

yomotsu
Copy link
Owner

@yomotsu yomotsu commented Sep 23, 2020 •
edited
Loading

I thought Dolly can be used for z-offset but may conflict with minDistance and maxDistance.
So, setFocalOffset() should take z-offset, like .setFocalOffset( x, y, z, true ).

Altho it does not affect in Orthographic...
(For a workaround for Ortho see #130 (comment) )

@yomotsu yomotsu merged commit c975871 into dev Sep 23, 2020
@yomotsu yomotsu mentioned this pull request Sep 23, 2020
Closed
@yomotsu yomotsu deleted the feature/focal-offset-3rd-argument branch October 21, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yomotsu