Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme.md to prompt the user to run CameraControls.install() #126

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Updated readme.md to prompt the user to run CameraControls.install() #126

merged 1 commit into from
Sep 7, 2020

Conversation

ACMCMC
Copy link
Contributor

@ACMCMC ACMCMC commented Sep 7, 2020

I ran into problems the first time I used camera-controls, because I didn't copy the example usage code, which contains the line CameraControls.install( { THREE: THREE } ). This is neccesary for camera-controls to work, but is not explicitly stated. I've added a warning to remind the user about the importance of running that line.

I ran into problems the first time I used camera-controls, because I didn't copy the example usage code, which contains the line CameraControls.install( { THREE: THREE } ). This is neccesary for camera-controls to work, but is not explicitly stated. I've added a warning to remind the user about the importance of running that line.
@yomotsu
Copy link
Owner

yomotsu commented Sep 7, 2020

Thanks! This should help other users too.

Maybe adding console.error( 'you must...' ) if THREE is undefined in the library would be nice as well?
Anyway I'll merge your PR for now 😄

@yomotsu yomotsu merged commit 65bd152 into yomotsu:dev Sep 7, 2020
@ACMCMC
Copy link
Contributor Author

ACMCMC commented Sep 8, 2020

Yes! Adding that would be great, I will take care of it ASAP :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants