Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant docker environment variables #1353

Merged
merged 1 commit into from
Aug 4, 2024
Merged

remove redundant docker environment variables #1353

merged 1 commit into from
Aug 4, 2024

Conversation

jxdv
Copy link
Contributor

@jxdv jxdv commented Aug 3, 2024

Already defined in:

rengine/web/Dockerfile

Lines 19 to 26 in 20543d8

# Environment Variables
ENV DEBIAN_FRONTEND="noninteractive" \
DATABASE="postgres"
ENV PYTHONDONTWRITEBYTECODE 1
ENV PYTHONUNBUFFERED 1
ENV GOROOT="/usr/local/go"
ENV GOPATH=$HOME/go
ENV PATH="${PATH}:${GOROOT}/bin:${GOPATH}/bin"

yogeshojha
yogeshojha reviewed Aug 4, 2024
View reviewed changes
Copy link
Owner

@yogeshojha yogeshojha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@yogeshojha yogeshojha merged commit 2e0b243 into yogeshojha:master Aug 4, 2024
3 of 6 checks passed
@jxdv jxdv deleted the remove-redundant-dockerfile-variables branch August 7, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogeshojha yogeshojha yogeshojha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxdv @yogeshojha