Fixed #459 #460 XSS

yogeshojha · Aug 23, 2021 · 412c5ce · 412c5ce
1 parent 7fe6707
commit 412c5ce
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.github/SECURITY.md b/.github/SECURITY.md
@@ -11,9 +11,13 @@ Please report all security issues [here](https://github.com/yogeshojha/rengine/i
 ## Past Security Vulnerabilities
 
 * [Stored XSS](https://github.com/yogeshojha/rengine/issues/178) on Detail Scan Page via Page Title Parameter, Reported by [omemishra](https://github.com/omemishra)
+
 * [Stored XSS](https://github.com/yogeshojha/rengine/issues/347) on Vulnerability Scan page via URL Parameter, Reported by [Arif Khan, payloadartist](https://twitter.com/payloadartist)
 
+* Several Instances of XSS in reNgine 1.0 (#460, #459, #458, #457, #456, #455), Reported by [Binit Ghimire](https://github.com/TheBinitGhimire)
+
 **reNgine thanks the following people for making a responsible disclosure and helping the community make reNgine safer!**
 
 * [onemishra](https://github.com/omemishra)
 * [Arif Khan, payloadartist](https://twitter.com/payloadartist)
+* [Binit Ghimire](https://github.com/TheBinitGhimire)
diff --git a/web/scanEngine/static/scanEngine/js/custom_scan_engine.js b/web/scanEngine/static/scanEngine/js/custom_scan_engine.js
@@ -20,11 +20,11 @@ $(document).ready(function() {
 } );
 
 
-function delete_api(id, name, item)
+function delete_api(id, item)
 {
     var delAPI = 'delete/'+id;
     swal.queue([{
-        title: 'Are you sure you want to delete '+ jsEscape(name) +'?',
+        title: 'Are you sure you want to delete this scan engine?',
         text: "You won't be able to revert this!",
         type: 'warning',
         showCancelButton: true,

diff --git a/web/scanEngine/templates/scanEngine/index.html b/web/scanEngine/templates/scanEngine/index.html
@@ -111,7 +111,7 @@ <h5>Scan Engines</h5>
                   <path d="M17 3a2.828 2.828 0 1 1 4 4L7.5 20.5 2 22l1.5-5.5L17 3z"></path>
                 </svg>
               </a>
-              <a onclick="delete_api({{ engine_type.id }}, '{{ engine_type.engine_name }}', 'engine')" class="bs-tooltip btnDelDomain" href="#" data-toggle="tooltip" data-placement="top" title="" data-original-title="Delete {{engine_type.engine_name}} Engine">
+              <a onclick="delete_api({{ engine_type.id }}, 'engine')" class="bs-tooltip btnDelDomain" href="#" data-toggle="tooltip" data-placement="top" title="" data-original-title="Delete {{engine_type.engine_name}} Engine">
                 <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="feather table-delete feather-x-circle">
                   <circle cx="12" cy="12" r="10"></circle>
                   <line x1="15" y1="9" x2="9" y2="15"></line>