Fix

yoanm · Jan 21, 2024 · f5493b1 · f5493b1
1 parent d66f1b4
commit f5493b1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/core/gh2tf_repo_mapper.go b/core/gh2tf_repo_mapper.go
@@ -26,8 +26,8 @@ const (
 var falseString = "false"
 
 // Replace branch protection pattern's special chars by dedicated string in order to avoid ID collision (pattern is used for TF ressource generation)
-// in case every special chars are replaced by the same string => "?.*", "[.]" or "?/?" would all lead to the same "---" ID for instance
-var patternToIdReplacer  = strings.NewReplacer(
+// in case every special chars are replaced by the same string => "?.*", "[.]" or "?/?" would all lead to the same "---" ID for instance.
+var patternToIdReplacer = strings.NewReplacer(
 	".", "_DOT_",
 	"/", "_SLASH_",
 	"\\", "_ESC_",

diff --git a/core/testdata/repo1.full.golden.tf b/core/testdata/repo1.full.golden.tf
@@ -87,7 +87,7 @@ resource "github_branch_protection" "repo1-default" {
   }
 }
 
-resource "github_branch_protection" "repo1-feature-branch1" {
+resource "github_branch_protection" "repo1-feature_SLASH_branch1" {
   repository_id           = github_repository.repo1.node_id
   pattern                 = "feature/branch1"
   enforce_admins          = true
@@ -111,7 +111,7 @@ resource "github_branch_protection" "repo1-feature-branch1" {
   }
 }
 
-resource "github_branch_protection" "repo1-feature-branch2" {
+resource "github_branch_protection" "repo1-feature_SLASH_branch2" {
   repository_id           = github_repository.repo1.node_id
   pattern                 = "feature/branch2"
   enforce_admins          = false

diff --git a/core/testdata/repo2.full.golden.tf b/core/testdata/repo2.full.golden.tf
@@ -87,7 +87,7 @@ resource "github_branch_protection" "repo2-default" {
   }
 }
 
-resource "github_branch_protection" "repo2-feature-branch2" {
+resource "github_branch_protection" "repo2-feature_SLASH_branch2" {
   repository_id           = github_repository.repo2.node_id
   pattern                 = "feature/branch2"
   enforce_admins          = false
@@ -111,7 +111,7 @@ resource "github_branch_protection" "repo2-feature-branch2" {
   }
 }
 
-resource "github_branch_protection" "repo2-feature-branch3" {
+resource "github_branch_protection" "repo2-feature_SLASH_branch3" {
   repository_id           = github_repository.repo2.node_id
   pattern                 = "feature/branch3"
   enforce_admins          = true