-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotations refactor #1044
Annotations refactor #1044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Innders sounds good, I've reduced the debounce delay (on latest powerpack branch) - I'll have a look at the border thing. It looks like an issue with the image aspect ratio |
@Innders added a "submitting" state to CommentInput, for now it's just non-interactive and greyed out. Lmk if that feels sufficient or you'd rather have a spinner over it, too |
@Innders added a 250ms transition with a 250ms delay, seems like a happy medium. Lmk what you think. Also, if you pull latest powerpack, the annotated images now have unique filenames. |
that should also fix the weird prefix dot. It was being added by the code that's meant to split file name from the extension, but it can't handle names without extensions 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, I'm excited to get this out for wider testing 👏
Description of changes
Adapt the Annotations Viewer integration to the new API coming in Powerpack v1.0.0.
Technical details
AnnotationsProvider
andAnnotationsEditorProvider
).AnnotationsProvider
wraps the whole Viewer incl. the activity feed, whileAnnotationsEditorProvider
just wraps the image/video and the toolbar.useAnnotations
hook which allowsCommentInput
to grab the annotations (viauseAnnotationsSync
)useViewerAnnotations
because its functionality is inside the addon now. The "unique annotated frames" logic has been moved toVideoPlayer
because that's the only place it's used.mediaType
,atMediaTime
andsrc
props to theAnnotationsEditorProvider
useAnnotationsUpload
we now use theuseAnnotations
hook to export the full-size composite image only when the comment is submitted.Additional context