Global Customizations: Allow to remove an uploaded image #1039
+35
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Innders
requested changes
Feb 21, 2025
Innders
requested changes
Feb 24, 2025
| <Button icon={loading ? 'sync' : 'upload'} onClick={handleButtonClick}> | ||
| Upload | ||
| </Button> | ||
| {fileName ? ( |
There was a problem hiding this comment.
Could we please have a consistent width of the buttons. I would go for 100px.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Toggle the upload component to "Remove" button if it currently contains an uploaded file so that you can remove things.
Technical details
@Innders visually it looks good - but I can't get the clear to actually influence the stored result. So when refreshing you can see it never actually 'cleared' anything.
Fix #1036
Additional context