Users: updating multiple users respects mixed fields #1004
Merged
+72
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martastain
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Selecting multiple users and changing one value would affect all values even if they were mixed. You could change one field and then an untouched field would be overwritten to one value for the selection. This could be dangerous as use permissions were part of this.
Now only fields that have been "touched" are updated, leaving alone fields with mixed state.
Screen.Recording.2025-01-30.at.08.24.28.mov
Testing
Select many users with different levels. Now change the guest switch and save. All selected users should have the same guest value but all other value, included level, should remain the same for each user.