Skip to content

Commit

Permalink
Further changes/updates to the dev environment
Browse files Browse the repository at this point in the history
  • Loading branch information
ylabonte committed Feb 11, 2024
1 parent 95ae1e1 commit b6d8337
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 70 deletions.
25 changes: 12 additions & 13 deletions .devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,36 +16,35 @@
"extensions": [
"ms-python.python",
"ms-python.black-formatter",
"github.vscode-pull-request-github",
"ryanluker.vscode-coverage-gutters",
"ms-python.vscode-pylance",
"github.vscode-github-actions"
"ryanluker.vscode-coverage-gutters",
"github.vscode-github-actions",
"github.vscode-pull-request-github"
],
"settings": {
"editor.defaultFormatter": "ms-python.black-formatter",
"editor.formatOnSave": true,
"editor.tabSize": 4,
"files.eol": "\n",
"files.trimTrailingWhitespace": true,
"pylint.enabled": true,
"python.analysis.typeCheckingMode": "strict",
"python.analysis.diagnosticMode": "workspace",
"python.analysis.include": ["custom_components/**/*.py"],
"python.analysis.autoSearchPaths": true,
"python.analysis.extraPaths": [
"python.pythonPath": "/usr/local/bin/python3.12",
"python.autoComplete.extraPaths": [
"/home/vscode/.local/lib/python3.12/site-packages",
"/usr/local/lib/python3.12/site-packages",
"/usr/local/lib/python3.12",
"/usr/local/lib/python3.12/lib-dynload",
"/usr/local/lib/python3.12/site-packages"
"/usr/local/lib/python3.12/lib-dynload"
],
"python.analysis.typeCheckingMode": "basic",
"python.analysis.diagnosticMode": "workspace",
"python.analysis.include": ["custom_components/**/*.py"],
"python.analysis.autoSearchPaths": true,
"python.analysis.indexing": true,
"python.analysis.autoImportCompletions": true,
"python.analysis.importFormat": "relative",
"python.analysis.inlayHints.variableTypes": true,
"python.analysis.inlayHints.functionReturnTypes": true,
"python.analysis.inlayHints.callArgumentNames": "all",
"python.analysis.inlayHints.pytestParameters": true,
"python.pythonPath": "/usr/local/bin/python3.12"
"python.analysis.inlayHints.pytestParameters": true
}
}
},
Expand Down
13 changes: 8 additions & 5 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ on:
- "main"

jobs:
ruff:
name: "Ruff"
lint:
name: "Lint using Black"
runs-on: "ubuntu-latest"
steps:
- name: "Checkout the repository"
Expand All @@ -19,11 +19,14 @@ jobs:
- name: "Set up Python"
uses: actions/setup-python@v5.0.0
with:
python-version: "3.11"
python-version: "3.12"
cache: "pip"

- name: "Install requirements"
run: python3 -m pip install -r requirements.txt

- name: "Run"
run: python3 -m ruff check .
- name: "Run Black"
uses: psf/black@stable
with:
options: "--check --verbose"
src: "./custom_components/proconip_pool_controller"
2 changes: 0 additions & 2 deletions .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,3 @@ jobs:
uses: "hacs/action@main"
with:
category: "integration"
# Remove this 'ignore' key when you have added brand images for your integration to https://github.com/home-assistant/brands
ignore: "brands"
48 changes: 0 additions & 48 deletions .ruff.toml

This file was deleted.

2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
colorlog>=6.8
homeassistant>=2024.2.1
pip>=24
pip>=21.3.1
ruff>=0.2
proconip>=1.3.0
2 changes: 1 addition & 1 deletion scripts/lint
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ set -e

cd "$(dirname "$0")/.."

ruff check . --fix
black --check --verbose custom_components/

0 comments on commit b6d8337

Please sign in to comment.