Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intrinsics as calls #1585

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Intrinsics as calls #1585

merged 3 commits into from
Feb 6, 2025

Conversation

ltratt
Copy link
Contributor

@ltratt ltratt commented Feb 6, 2025

This PR ignores / codegens several LLVM intrinsics that are disguised as calls. These crop up frequently in traces, and cause us to abort compiling.

@vext01 vext01 added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@ltratt
Copy link
Contributor Author

ltratt commented Feb 6, 2025 •
edited
Loading

I have seen the ykd_opt_off test fail once before and I haven't been able to replicate it since. Nothing in this PR effects it (unless I've missed something very obvious!) so I think we should retry, but we should keep an eye on ykd_opt_off for other reasons.

@vext01 vext01 added this pull request to the merge queue Feb 6, 2025
Merged via the queue into ykjit:master with commit a448856 Feb 6, 2025
2 checks passed
@ltratt ltratt mentioned this pull request Feb 6, 2025
Open
@ltratt ltratt deleted the intrinsics_as_calls branch February 6, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vext01 vext01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltratt @vext01