Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly mark nullable parameters #286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Explicitly mark nullable parameters #286

wants to merge 1 commit into from

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 24, 2025

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 96.08%. Comparing base (6882416) to head (c7bbdf1).

Files with missing lines Patch % Lines
src/AbstractMigrationBuilder.php 18.75% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #286   +/-   ##
=========================================
  Coverage     96.08%   96.08%           
  Complexity      312      312           
=========================================
  Files            21       21           
  Lines          1047     1047           
=========================================
  Hits           1006     1006           
  Misses           41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team February 24, 2025 15:18
@vjik vjik added the status:code review The pull request needs review. label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant