Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use Config without params #131

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Add ability to use Config without params #131

merged 1 commit into from
Feb 11, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 9, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues -

@vjik vjik added the status:code review The pull request needs review. label Feb 9, 2023
@vjik vjik requested a review from a team February 9, 2023 06:50
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 99.57% // Head: 99.57% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c9e860d) compared to base (8cc9c42).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #131   +/-   ##
=========================================
  Coverage     99.57%   99.57%           
- Complexity      270      272    +2     
=========================================
  Files            22       22           
  Lines           705      706    +1     
=========================================
+ Hits            702      703    +1     
  Misses            3        3           
Impacted Files Coverage Δ
src/Config.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vjik vjik merged commit fba8824 into master Feb 11, 2023
@vjik vjik deleted the null-params branch February 11, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants