-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disabling built-in CSS classes for FilterSearch component #482
Conversation
To address #481 Adds a new flag to FilterSearchProps named disableBuiltInClasses. If this property is true, and there are customCssClasses set, then we will completely remove the builtin CSS classes from the component. TEST=manual Spun up test site and set the property on a component. Saw the classes get replaced as expected.
Current unit coverage is 92.08312716476992% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to increment the version. Maybe a new minor version? Could be argued this is kinda like a bugfix though, so I could be fine with a patch. I see an older pull request with Max that hasn't been shipped. May be worth syncing with him real quick to see what the state of that is.
I was thinking that I'd just roll up Max's change at the same time and keep the (The parent branch of this one will have the wrong name though but that's fine) |
Add a new flag to FilterSearchProps named disableBuiltInClasses.
To address #481
If this property is true, and there are customCssClasses set, then
we will completely remove the builtin CSS classes from the
component.
TEST=manual
Spun up test site and set the property on a component. Saw the
classes get replaced as expected.