feat(custom): add onDropdownInputChange optional prop to FilterSearch #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current unit coverage is 92.65223955712129% |
benmcginnis
reviewed
Jan 17, 2024
There was a problem hiding this comment.
@nmanu1 if you could take a look as well, I'd appreciate it!
nmanu1
reviewed
Jan 17, 2024
3f2edd1 to
5545f1f
Compare
benmcginnis
approved these changes
Jan 23, 2024
nmanu1
reviewed
Jan 23, 2024
.storybook/snapshots/__snapshots__/filtersearch--dropdown-sectioned.png
Outdated
Show resolved
Hide resolved
nmanu1
reviewed
Jan 23, 2024
expose a callback prop to be called everytime after input changes in the FilterSearch component. This enables greater customization for our Locators that are built using FilterSearch primarily J=BACK-2765 TEST=manual
…havior, add documentation specify a type for the props passed into onDropdownInputSelect and pass back the searchFields used in the FilterSearch component so we can properly remove/keep the right filters J=BACK-2765 TEST=manual
fc0ac1b to
ee26218
Compare
…pdownInputChange is specified ensure executeFilterSearch is not called in test when onDropdownInputChange is supplied J=BACK-2765 TEST=manual
nmanu1
reviewed
Jan 24, 2024
81ed215 to
ff27627
Compare
J=BACK-2765 TEST=manual
ff27627 to
d177678
Compare
nmanu1
reviewed
Jan 24, 2024
…o args move executeFilterSearch check to be outside a callback J=BACK-2765 TEST=manual
nmanu1
approved these changes
Jan 24, 2024
nmanu1
added a commit
that referenced
this pull request
Feb 20, 2024
Merged
nmanu1
added a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose a callback prop to be called everytime after input changes in the FilterSearch component. This enables greater customization for our Locators that are built using FilterSearch primarily
J=BACK-2765
TEST=manual