Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade @babel/traverse #409

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Upgrade @babel/traverse #409

merged 3 commits into from
Dec 7, 2023

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Dec 6, 2023 •
edited
Loading

Upgrade @babel/traverse from v7.23.0 (in top-level package-lock) and v7.20.1 (in the test site's package-lock) to 7.23.5 to address a critical vulnerability in the package.

Also, add some changes from running ESLint locally, since the linting PR check doesn't currently work.

J=VULN-38476, VULN-38477
TEST=auto

@coveralls
Copy link

coveralls commented Dec 6, 2023 •
edited
Loading

Coverage Status

coverage: 85.159% (+0.004%) from 85.155%
when pulling 5ca94b1 on dev/upgrade-babel-traverse
into f8fd9fe on develop.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023 •
edited
Loading

Current unit coverage is 92.18045112781955%
Current visual coverage is 78.34757834757835%
Current combined coverage is 92.68537074148297%

@nmanu1 nmanu1 marked this pull request as ready for review December 6, 2023 22:48
@nmanu1 nmanu1 requested a review from a team as a code owner December 6, 2023 22:48
benmcginnis
benmcginnis approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@benmcginnis benmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nmanu1 nmanu1 merged commit 5d0160c into develop Dec 7, 2023
16 of 18 checks passed
@nmanu1 nmanu1 deleted the dev/upgrade-babel-traverse branch December 7, 2023 22:11
@nmanu1 nmanu1 mentioned this pull request Dec 8, 2023
Merged
nmanu1 added a commit that referenced this pull request Dec 8, 2023
@nmanu1
Version 1.4.0 (#411)
a5e8a64 
### Changes
- Added compatibility with PagesJS v1 (#400, #402, #404)
### Fixes
- Upgraded `@babel/traverse` version to address a vulnerability in the package (#409)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmcginnis benmcginnis benmcginnis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmanu1 @coveralls @benmcginnis