Make matchedSubstrings accessible #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2741054734
💛 - Coveralls |
yen-tt
approved these changes
Jul 26, 2022
Merged
alextaing
added a commit
that referenced
this pull request
Jul 27, 2022
## Version 1.4.0 ### Changes - `matchedSubstrings` from `spellCheck` is now accessible in state (#126) - An array of objects with properties `offset` and `length` that represent the matching substrings between the `originalQuery` and the `correctedQuery`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raiden needs access to
matchedSubstringsfrom the spellCheck part of the Search API response. Since changingcorrectedQueryfrom a string to an object would be a breaking change, we added a new property to the spellCheck interface that holds thematchedSubstrings. This PR updates the version number of Core used to introducematchedSubstrings.J=SLAP-2274
TEST=auto, manual
Automatic tests were updated to include
matchedSubstringsin the SpellCheck objects. Manual testing was performed using the test-site-node. It was checked that on search "virgimia", amatchedSubstringslist was returned with correct values. It was also checked that on search "virginia" remained functional."virgimia" search result:
