feat(pages-components): restore productionDomains AnalyticsProvider prop #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restores the productionDomains param for the AnalyticsProvider. If productionDomains is present and matches the hostname, then analytics will be enabled. TEST=auto
|
mkilpatrick
reviewed
Mar 7, 2025
packages/pages-components/src/components/analytics/interfaces.ts
Outdated
Show resolved
Hide resolved
packages/pages-components/src/components/analytics/Analytics.ts
Outdated
Show resolved
Hide resolved
mkilpatrick
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the productionDomains param for the AnalyticsProvider. It is used as a fallback after checking the IS_PRODUCTION variable. This is necessary for analytics to work when the code is used in the context of a Yext module because the hosting domain may not be served by Yext.