-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for predefined consumers of CDC topics #119
Merged
nvamelichev
merged 8 commits into
ydb-platform:main
from
Eistern:feature/predefined-consumers-for-cdc
Jan 21, 2025
Merged
Support for predefined consumers of CDC topics #119
nvamelichev
merged 8 commits into
ydb-platform:main
from
Eistern:feature/predefined-consumers-for-cdc
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update replicates terraform resource behavior (https://ydb.tech/docs/en/dev/terraform#ydb-table-changefeed) and allows the user to implement non-trivial CDC reading logic without worrying about creation of the consumers |
nvamelichev
requested changes
Jan 20, 2025
repository-ydb-v2/src/main/java/tech/ydb/yoj/repository/ydb/client/YdbSchemaOperations.java
Show resolved
Hide resolved
nvamelichev
requested changes
Jan 20, 2025
databind/src/main/java/tech/ydb/yoj/databind/schema/Changefeed.java
Outdated
Show resolved
Hide resolved
nvamelichev
approved these changes
Jan 21, 2025
nvamelichev
pushed a commit
that referenced
this pull request
Feb 11, 2025
Adding an option to specify a list of consumers that will be created alongside the CDC topic during the initial bootstrap of the application. A minor consideration is that TopicService/AlterTopic is not idempotent and will throw an exception if we specify already existing consumers in the addConsumer block. To address this behavior, we will perform a describe operation each time a table is attempted to be created. These changes have been tested against local YDB (ydbplatform/local-ydb:latest version). --------- Co-authored-by: Daniil Zulin <daniil-zulin@yandex-team.ru>
Fixed in release 2.6.6 (already on Maven Central). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we are adding an option to specify a list of consumers that will be created alongside the CDC topic during the initial bootstrap of the application.
A minor consideration is that TopicService/AlterTopic is not idempotent and will throw an exception if we specify already existing consumers in the addConsumer block. To address this behavior, we will perform a describe operation each time a table is attempted to be created.
These changes have been tested against local YDB (ydbplatform/local-ydb:latest version).