Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor maintenance options #44

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Refactor maintenance options #44

merged 7 commits into from
Dec 9, 2024

Conversation

Jorres
Copy link
Contributor

@Jorres Jorres commented Nov 19, 2024

  1. no longer use options from restart subtree: it made absolutely zero sense that ydbops maintenance --help suddenly had something like --ssh-args or --systemd-unit. Massive refactor of options under the hood, created a new option type for intersecting options between maintenance and restart commands.

  2. fixed a series of bugs which prevented ydbops maintenance create --hosts=<id1>,<id2> from working (specifying an FQDN worked)

  3. filters such as started or version now work on ydbops maintenance create as well, if you need to create an extra large \ complicated task for some reason (e.g. ydbops maintenance create --hosts=1-1000 --version=...)

  4. stop logging a DRAINING warning on Warn level and only log it on Info level (with --verbose enabled)

@Jorres Jorres requested a review from shmel1k November 20, 2024 12:07
pkg/options/filtering.go Outdated Show resolved Hide resolved
@Jorres Jorres merged commit f365888 into master Dec 9, 2024
2 checks passed
@Jorres Jorres mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants