Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24-3: Fix GetAliveChildren with filter by type #9934

Merged

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Oct 1, 2024

Changelog entry

Exclude dropped indexes from limits.

Changelog category

  • Bugfix

Additional information

...

@CyberROFL CyberROFL self-assigned this Oct 1, 2024
@CyberROFL CyberROFL marked this pull request as ready for review October 1, 2024 14:19
@CyberROFL CyberROFL requested a review from a team as a code owner October 1, 2024 14:19
Copy link

github-actions bot commented Oct 1, 2024

2024-10-01 14:22:06 UTC Pre-commit check for 47c1098 has started.
2024-10-01 14:24:39 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-01 14:48:10 UTC Build successful.
2024-10-01 14:48:26 UTC Tests are running...
🔴 2024-10-01 16:42:09 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10040 9959 0 6 27 48

🟢 2024-10-01 16:42:44 UTC ydbd size 5.6 GiB changed* by +896 Bytes, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: ea4f43c merge: 47c1098 diff diff %
ydbd size 5 961 199 704 Bytes 5 961 200 600 Bytes +896 Bytes +0.000%
ydbd stripped size 1 491 898 432 Bytes 1 491 898 688 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 1, 2024

2024-10-01 14:22:08 UTC Pre-commit check for 47c1098 has started.
2024-10-01 14:24:39 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-01 14:32:21 UTC Build successful.

Copy link

github-actions bot commented Oct 1, 2024

2024-10-01 14:22:48 UTC Pre-commit check for 47c1098 has started.
2024-10-01 14:25:21 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-01 15:04:42 UTC Build successful.
2024-10-01 15:05:00 UTC Tests are running...
🔴 2024-10-01 16:29:08 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14340 12992 0 6 1299 43

🟢 2024-10-01 16:29:59 UTC ydbd size 8.2 GiB changed* by -64 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: ea4f43c merge: 47c1098 diff diff %
ydbd size 8 802 966 720 Bytes 8 802 966 656 Bytes -64 Bytes -0.000%
ydbd stripped size 480 044 392 Bytes 480 044 456 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL enabled auto-merge (squash) October 1, 2024 18:06
@CyberROFL CyberROFL merged commit 465f1c5 into ydb-platform:stable-24-3 Oct 2, 2024
8 of 12 checks passed
@CyberROFL CyberROFL deleted the fix-get-alive-children-24-3 branch October 2, 2024 09:07
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Oct 7, 2024
zinal pushed a commit to zinal/ydb that referenced this pull request Oct 21, 2024
zinal pushed a commit to zinal/ydb that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants