Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactoring] Get rid of "GetPeer()" grpc request implementation copy paste and unused functions #9814

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

dcherednik
Copy link
Member

No description provided.

Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 14:10:29 UTC Pre-commit check linux-x86_64-release-asan for 03f3a00 has started.
2024-09-26 14:10:39 UTC Artifacts will be uploaded here
2024-09-26 14:13:46 UTC ya make is running...
🟡 2024-09-26 16:35:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11949 11726 0 56 46 121

🟢 2024-09-26 16:36:12 UTC Build successful.
🟡 2024-09-26 16:37:18 UTC ydbd size 5.7 GiB changed* by +312.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7cfcc44 merge: 03f3a00 diff diff %
ydbd size 6 084 272 272 Bytes 6 084 591 872 Bytes +312.1 KiB +0.005%
ydbd stripped size 1 520 825 392 Bytes 1 520 867 632 Bytes +41.2 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 14:10:32 UTC Pre-commit check linux-x86_64-release-clang14 for 03f3a00 has started.
2024-09-26 14:10:41 UTC Artifacts will be uploaded here
2024-09-26 14:14:01 UTC ya make is running...
🟢 2024-09-26 15:06:52 UTC Build successful.

Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 14:10:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 03f3a00 has started.
2024-09-26 14:10:57 UTC Artifacts will be uploaded here
2024-09-26 14:14:04 UTC ya make is running...
🟡 2024-09-26 15:55:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41329 35509 0 9 5773 38

2024-09-26 15:58:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-26 16:09:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
367 (only retried tests) 269 0 1 7 90

2024-09-26 16:10:05 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-26 16:21:18 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
96 (only retried tests) 6 0 1 0 89

🟢 2024-09-26 16:21:24 UTC Build successful.
🟡 2024-09-26 16:22:02 UTC ydbd size 8.5 GiB changed* by +240.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7cfcc44 merge: 03f3a00 diff diff %
ydbd size 9 080 256 456 Bytes 9 080 502 624 Bytes +240.4 KiB +0.003%
ydbd stripped size 490 858 952 Bytes 490 866 632 Bytes +7.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik requested review from a team as code owners September 26, 2024 17:56
@dcherednik dcherednik changed the title [refactoring] Get rid of "GetPeer()" grpc request implementation copy paste [refactoring] Get rid of "GetPeer()" grpc request implementation copy paste and unused functions Sep 26, 2024
Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 17:59:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9165cc8 has started.
2024-09-26 18:00:46 UTC Artifacts will be uploaded here
2024-09-26 18:04:29 UTC ya make is running...
🟡 2024-09-26 19:51:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41327 35758 0 8 5462 99

2024-09-26 19:55:20 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-26 20:07:16 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
112 (only retried tests) 22 0 0 0 90

🟢 2024-09-26 20:07:23 UTC Build successful.
🟢 2024-09-26 20:08:05 UTC ydbd size 8.5 GiB changed* by -497.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: c1eb495 merge: 9165cc8 diff diff %
ydbd size 9 083 072 312 Bytes 9 082 562 632 Bytes -497.7 KiB -0.006%
ydbd stripped size 490 936 552 Bytes 490 867 496 Bytes -67.4 KiB -0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 18:00:41 UTC Pre-commit check linux-x86_64-release-asan for 9165cc8 has started.
2024-09-26 18:00:51 UTC Artifacts will be uploaded here
2024-09-26 18:04:05 UTC ya make is running...
🟡 2024-09-26 20:29:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11954 11719 0 65 49 121

🟢 2024-09-26 20:30:00 UTC Build successful.
🟢 2024-09-26 20:30:34 UTC ydbd size 5.7 GiB changed* by -328.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: c1eb495 merge: 9165cc8 diff diff %
ydbd size 6 085 674 208 Bytes 6 085 338 160 Bytes -328.2 KiB -0.006%
ydbd stripped size 1 521 103 152 Bytes 1 520 882 384 Bytes -215.6 KiB -0.015%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik enabled auto-merge (squash) September 30, 2024 10:38
@dcherednik dcherednik merged commit fbe6aca into ydb-platform:main Sep 30, 2024
11 checks passed
pashandor789 pushed a commit to pashandor789/ydb that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants