Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

immediate write for bulk upsert #9489

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

  • Improvement
  • Performance improvement

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 09:53:13 UTC Pre-commit check linux-x86_64-release-asan for ef85a68 has started.
2024-09-19 09:53:23 UTC Artifacts will be uploaded here
2024-09-19 09:56:42 UTC ya make is running...
🔴 2024-09-19 12:32:19 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14521 14296 0 50 64 111

🟢 2024-09-19 12:33:36 UTC Build successful.
🟡 2024-09-19 12:34:13 UTC ydbd size 5.6 GiB changed* by +177.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8d55710 merge: ef85a68 diff diff %
ydbd size 6 058 346 624 Bytes 6 058 528 600 Bytes +177.7 KiB +0.003%
ydbd stripped size 1 515 539 760 Bytes 1 515 557 488 Bytes +17.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 09:53:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for ef85a68 has started.
2024-09-19 09:53:26 UTC Artifacts will be uploaded here
2024-09-19 09:56:56 UTC ya make is running...
🟡 2024-09-19 11:53:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77042 63069 0 10 13841 122

2024-09-19 12:00:50 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-19 12:12:22 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
170 (only retried tests) 78 0 0 0 92

🟢 2024-09-19 12:12:30 UTC Build successful.
🟡 2024-09-19 12:13:14 UTC ydbd size 8.4 GiB changed* by +244.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8d55710 merge: ef85a68 diff diff %
ydbd size 9 040 538 568 Bytes 9 040 789 320 Bytes +244.9 KiB +0.003%
ydbd stripped size 489 103 048 Bytes 489 106 824 Bytes +3.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 09:53:41 UTC Pre-commit check linux-x86_64-release-clang14 for ef85a68 has started.
2024-09-19 09:53:44 UTC Artifacts will be uploaded here
2024-09-19 09:57:14 UTC ya make is running...
🟢 2024-09-19 10:51:50 UTC Build successful.

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 14:26:02 UTC Pre-commit check linux-x86_64-release-clang14 for c34c65b has started.
2024-09-19 14:26:12 UTC Artifacts will be uploaded here
2024-09-19 14:29:31 UTC ya make is running...
2024-09-19 14:32:48 UTC Check cancelled

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 14:26:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for c34c65b has started.
2024-09-19 14:27:08 UTC Artifacts will be uploaded here
2024-09-19 14:30:17 UTC ya make is running...
2024-09-19 14:32:46 UTC Check cancelled

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 14:26:58 UTC Pre-commit check linux-x86_64-release-asan for c34c65b has started.
2024-09-19 14:27:08 UTC Artifacts will be uploaded here
2024-09-19 14:30:18 UTC ya make is running...
2024-09-19 14:32:48 UTC Check cancelled

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 14:34:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9490588 has started.
2024-09-19 14:34:36 UTC Artifacts will be uploaded here
2024-09-19 14:37:45 UTC ya make is running...
2024-09-19 14:51:23 UTC Check cancelled

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 14:35:34 UTC Pre-commit check linux-x86_64-release-clang14 for 9490588 has started.
2024-09-19 14:36:11 UTC Artifacts will be uploaded here
2024-09-19 14:39:35 UTC ya make is running...
2024-09-19 14:51:23 UTC Check cancelled

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 14:35:58 UTC Pre-commit check linux-x86_64-release-asan for 9490588 has started.
2024-09-19 14:36:11 UTC Artifacts will be uploaded here
2024-09-19 14:39:20 UTC ya make is running...
🔴 2024-09-19 14:48:41 UTC Build failed, see the logs.

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 14:56:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for dde9d06 has started.
2024-09-19 14:57:01 UTC Artifacts will be uploaded here
2024-09-19 15:00:40 UTC ya make is running...
🔴 2024-09-19 15:23:45 UTC Build failed, see the logs.

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 14:56:13 UTC Pre-commit check linux-x86_64-release-asan for dde9d06 has started.
2024-09-19 14:56:24 UTC Artifacts will be uploaded here
2024-09-19 14:59:34 UTC ya make is running...
🔴 2024-09-19 15:12:35 UTC Build failed, see the logs.

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 14:56:16 UTC Pre-commit check linux-x86_64-release-clang14 for dde9d06 has started.
2024-09-19 14:56:26 UTC Artifacts will be uploaded here
2024-09-19 14:59:44 UTC ya make is running...
🔴 2024-09-19 15:06:06 UTC Build failed, see the logs.

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 15:39:07 UTC Pre-commit check linux-x86_64-release-clang14 for 59d23ca has started.
2024-09-19 15:39:18 UTC Artifacts will be uploaded here
2024-09-19 15:42:31 UTC ya make is running...
🟢 2024-09-19 16:27:19 UTC Build successful.

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 15:39:20 UTC Pre-commit check linux-x86_64-release-asan for 59d23ca has started.
2024-09-19 15:39:30 UTC Artifacts will be uploaded here
2024-09-19 15:42:47 UTC ya make is running...
🟡 2024-09-19 17:51:54 UTC ydbd size 5.6 GiB changed* by +180.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 56fbcfc merge: 59d23ca diff diff %
ydbd size 6 060 489 768 Bytes 6 060 674 856 Bytes +180.8 KiB +0.003%
ydbd stripped size 1 516 100 592 Bytes 1 516 122 800 Bytes +21.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-09-19 17:51:56 UTC Check cancelled

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 15:41:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 59d23ca has started.
2024-09-19 15:41:42 UTC Artifacts will be uploaded here
2024-09-19 15:44:52 UTC ya make is running...
🟡 2024-09-19 17:05:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41267 35447 0 8 5771 41

2024-09-19 17:09:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-19 17:21:08 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
385 (only retried tests) 286 0 0 7 92

🟢 2024-09-19 17:21:16 UTC Build successful.
🟡 2024-09-19 17:21:55 UTC ydbd size 8.4 GiB changed* by +242.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 56fbcfc merge: 59d23ca diff diff %
ydbd size 9 041 979 000 Bytes 9 042 226 904 Bytes +242.1 KiB +0.003%
ydbd stripped size 489 272 424 Bytes 489 276 008 Bytes +3.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 17:56:13 UTC Pre-commit check linux-x86_64-release-clang14 for 4bc723f has started.
2024-09-19 17:56:23 UTC Artifacts will be uploaded here
2024-09-19 17:59:33 UTC ya make is running...
🟢 2024-09-19 18:42:09 UTC Build successful.

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 17:56:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4bc723f has started.
2024-09-19 17:56:24 UTC Artifacts will be uploaded here
2024-09-19 17:59:33 UTC ya make is running...
🟡 2024-09-19 19:37:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41267 35551 0 6 5668 42

2024-09-19 19:41:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-19 19:52:45 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
279 (only retried tests) 181 0 0 7 91

🟢 2024-09-19 19:52:52 UTC Build successful.
🟡 2024-09-19 19:53:31 UTC ydbd size 8.4 GiB changed* by +231.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7b891d8 merge: 4bc723f diff diff %
ydbd size 9 041 891 152 Bytes 9 042 128 184 Bytes +231.5 KiB +0.003%
ydbd stripped size 489 265 288 Bytes 489 268 968 Bytes +3.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 17:56:14 UTC Pre-commit check linux-x86_64-release-asan for 4bc723f has started.
2024-09-19 17:56:24 UTC Artifacts will be uploaded here
2024-09-19 17:59:40 UTC ya make is running...
🔴 2024-09-19 20:18:44 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11901 11685 0 57 48 111

🟢 2024-09-19 20:19:43 UTC Build successful.
🟡 2024-09-19 20:20:18 UTC ydbd size 5.6 GiB changed* by +163.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7b891d8 merge: 4bc723f diff diff %
ydbd size 6 060 459 032 Bytes 6 060 626 160 Bytes +163.2 KiB +0.003%
ydbd stripped size 1 516 088 240 Bytes 1 516 106 160 Bytes +17.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 changed the title Ff protocol bulk upsert immediate write for bulk upsert Sep 20, 2024
Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 05:49:29 UTC Pre-commit check linux-x86_64-release-clang14 for d29411c has started.
2024-09-20 05:49:38 UTC Artifacts will be uploaded here

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 05:49:33 UTC Pre-commit check linux-x86_64-release-asan for d29411c has started.
2024-09-20 05:49:43 UTC Artifacts will be uploaded here

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 05:52:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for d29411c has started.
2024-09-20 05:52:32 UTC Artifacts will be uploaded here

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 07:01:09 UTC Pre-commit check linux-x86_64-release-asan for f1d57e4 has started.
2024-09-20 07:01:20 UTC Artifacts will be uploaded here
2024-09-20 07:02:01 UTC Check cancelled

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 07:01:12 UTC Pre-commit check linux-x86_64-release-clang14 for f1d57e4 has started.
2024-09-20 07:01:23 UTC Artifacts will be uploaded here
2024-09-20 07:02:01 UTC Check cancelled

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 07:03:25 UTC Pre-commit check linux-x86_64-release-asan for 9453815 has started.
2024-09-20 07:03:29 UTC Artifacts will be uploaded here
2024-09-20 07:06:39 UTC ya make is running...
🔴 2024-09-20 07:27:54 UTC Build failed, see the logs.

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 08:13:11 UTC Pre-commit check linux-x86_64-release-asan for baca823 has started.
2024-09-20 08:13:22 UTC Artifacts will be uploaded here
2024-09-20 08:16:37 UTC ya make is running...
2024-09-20 10:08:51 UTC Check cancelled

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 10:10:18 UTC Pre-commit check linux-x86_64-release-asan for f834783 has started.
2024-09-20 10:10:28 UTC Artifacts will be uploaded here
2024-09-20 10:13:40 UTC ya make is running...
🔴 2024-09-20 12:07:31 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11895 11653 0 73 56 113

🟢 2024-09-20 12:08:33 UTC Build successful.
🟡 2024-09-20 12:09:08 UTC ydbd size 5.6 GiB changed* by +265.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 77a5f3a merge: f834783 diff diff %
ydbd size 6 060 680 096 Bytes 6 060 951 592 Bytes +265.1 KiB +0.004%
ydbd stripped size 1 516 142 384 Bytes 1 516 193 840 Bytes +50.2 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 10:12:45 UTC Pre-commit check linux-x86_64-release-clang14 for f834783 has started.
2024-09-20 10:12:56 UTC Artifacts will be uploaded here
2024-09-20 10:16:05 UTC ya make is running...
🟢 2024-09-20 10:23:37 UTC Build successful.

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 10:12:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for f834783 has started.
2024-09-20 10:13:06 UTC Artifacts will be uploaded here
2024-09-20 10:16:17 UTC ya make is running...
🟡 2024-09-20 11:23:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41271 35540 0 8 5677 46

2024-09-20 11:26:47 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-20 11:38:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
293 (only retried tests) 193 0 1 7 92

2024-09-20 11:38:21 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-20 11:49:31 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 5 0 1 0 92

🟢 2024-09-20 11:49:38 UTC Build successful.
🟡 2024-09-20 11:50:26 UTC ydbd size 8.4 GiB changed* by +346.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 77a5f3a merge: f834783 diff diff %
ydbd size 9 042 177 512 Bytes 9 042 532 520 Bytes +346.7 KiB +0.004%
ydbd stripped size 489 288 072 Bytes 489 300 712 Bytes +12.3 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 12:28:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for f8c0943 has started.
2024-09-20 12:29:14 UTC Artifacts will be uploaded here
2024-09-20 12:33:06 UTC ya make is running...
🟡 2024-09-20 13:57:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41286 35493 0 24 5713 56

2024-09-20 14:00:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-20 14:12:18 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
343 (only retried tests) 243 0 0 7 93

🟢 2024-09-20 14:12:27 UTC Build successful.
🟡 2024-09-20 14:13:08 UTC ydbd size 8.4 GiB changed* by +357.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6c407dc merge: f8c0943 diff diff %
ydbd size 9 042 691 720 Bytes 9 043 057 672 Bytes +357.4 KiB +0.004%
ydbd stripped size 489 300 744 Bytes 489 310 056 Bytes +9.1 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 12:29:50 UTC Pre-commit check linux-x86_64-release-asan for f8c0943 has started.
2024-09-20 12:30:01 UTC Artifacts will be uploaded here
2024-09-20 12:33:12 UTC ya make is running...
🔴 2024-09-20 14:27:45 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11890 11685 0 30 56 119

🟢 2024-09-20 14:28:46 UTC Build successful.
🟡 2024-09-20 14:29:31 UTC ydbd size 5.6 GiB changed* by +267.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6c407dc merge: f8c0943 diff diff %
ydbd size 6 061 116 440 Bytes 6 061 390 072 Bytes +267.2 KiB +0.005%
ydbd stripped size 1 516 196 848 Bytes 1 516 242 608 Bytes +44.7 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 12:30:23 UTC Pre-commit check linux-x86_64-release-clang14 for f8c0943 has started.
2024-09-20 12:31:21 UTC Artifacts will be uploaded here
2024-09-20 12:35:13 UTC ya make is running...
🟢 2024-09-20 12:54:23 UTC Build successful.

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review September 20, 2024 14:34
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner September 20, 2024 14:34
@ivanmorozov333 ivanmorozov333 enabled auto-merge (squash) September 20, 2024 14:45
@@ -282,6 +284,7 @@ class TUploadRowsBase : public TActorBootstrapped<TUploadRowsBase<DerivedActivit

void Bootstrap(const NActors::TActorContext& ctx) {
StartTime = TAppData::TimeProvider->Now();
ImmediateWrite = AppData(ctx)->FeatureFlags.GetEnableImmediateWritingOnBulkUpsert();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather initialise it in the constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants