Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24-3: Forbid scheme ops on backup table #9446

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Sep 18, 2024

Changelog entry

Scheme operations (e.g. AlterTable) are now forbidden on backup tables.

Changelog category

  • Bugfix

Additional information

...

@CyberROFL CyberROFL self-assigned this Sep 18, 2024
@CyberROFL CyberROFL marked this pull request as ready for review September 18, 2024 13:18
@CyberROFL CyberROFL requested a review from a team as a code owner September 18, 2024 13:18
Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 13:20:26 UTC Pre-commit check for 71941ba has started.
2024-09-18 13:22:58 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-18 14:01:01 UTC Build successful.
2024-09-18 14:01:16 UTC Tests are running...
🔴 2024-09-18 15:32:06 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14235 12895 0 6 1302 32

🟢 2024-09-18 15:33:18 UTC ydbd size 8.2 GiB changed* by +3.8 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: bea65c7 merge: 71941ba diff diff %
ydbd size 8 763 580 528 Bytes 8 763 584 368 Bytes +3.8 KiB +0.000%
ydbd stripped size 479 088 584 Bytes 479 088 392 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 13:20:28 UTC Pre-commit check for 71941ba has started.
2024-09-18 13:23:06 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-18 13:29:55 UTC Build successful.

Copy link

github-actions bot commented Sep 18, 2024

2024-09-18 13:20:47 UTC Pre-commit check for 71941ba has started.
2024-09-18 13:23:19 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-18 13:46:17 UTC Build successful.
2024-09-18 13:46:35 UTC Tests are running...
🔴 2024-09-18 15:56:10 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9933 9869 0 6 24 34

🟢 2024-09-18 15:56:50 UTC ydbd size 5.5 GiB changed* by -16.4 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 75f6b27 merge: 71941ba diff diff %
ydbd size 5 935 252 840 Bytes 5 935 236 008 Bytes -16.4 KiB -0.000%
ydbd stripped size 1 487 984 960 Bytes 1 487 981 504 Bytes -3.4 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL merged commit c157964 into ydb-platform:stable-24-3 Sep 18, 2024
6 of 11 checks passed
@CyberROFL CyberROFL deleted the forbid-scheme-ops-on-backup-table-24-3 branch September 18, 2024 18:13
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants