Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document locks and change visibility in datashard YDBDOCS-430 YDBDOCS-431 #912

Merged
merged 11 commits into from
Feb 5, 2024
Merged

Document locks and change visibility in datashard YDBDOCS-430 YDBDOCS-431 #912

merged 11 commits into from
Feb 5, 2024

Conversation

snaury
Copy link
Member

@snaury snaury commented Jan 10, 2024

Includes some suggested changes from two formerly internal pull requests.

@snaury snaury requested review from blinkov, kunga and azevaykin January 10, 2024 12:25
@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision builded successful
Revision preview link

@snaury snaury marked this pull request as ready for review January 10, 2024 12:31
@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision builded successful
Revision preview link

@snaury snaury marked this pull request as draft January 12, 2024 08:31
@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision builded successful
Revision preview link

@snaury snaury marked this pull request as ready for review January 12, 2024 10:26
@snaury snaury requested a review from kunga January 12, 2024 10:26
@snaury snaury force-pushed the YDBDOCS-430-datashard-change-visibility branch from 8a5428b to 582aded Compare January 12, 2024 10:28
@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision builded successful
Revision preview link

azevaykin
azevaykin reviewed Jan 12, 2024
View reviewed changes
blinkov
blinkov requested changes Jan 16, 2024
View reviewed changes
fomichev3000
fomichev3000 requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@fomichev3000 fomichev3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

замените, пожалуйста "кол-во" на "количество". Можно прям search and replace

snaury and others added 4 commits January 16, 2024 16:31
@snaury
Document persistent uncommitted changes, locks and change visibility …
8eb6be2 
…in datashard YDBDOCS-430 YDBDOCS-431
@snaury @kunga
Apply suggestions from code review
dd8d3dc 
Co-authored-by: kungurtsev <alexey66rus@gmail.com>
@snaury
Proofread changes
09d9ccc
@snaury @blinkov
Apply suggestions from code review
b52ee97 
Co-authored-by: Ivan Blinkov <ivan@blinkov.ru>
@snaury snaury force-pushed the YDBDOCS-430-datashard-change-visibility branch from 84d668f to bd6507a Compare January 16, 2024 13:32
@snaury snaury requested a review from a team as a code owner January 16, 2024 13:32
@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision builded successful
Revision preview link

@snaury snaury force-pushed the YDBDOCS-430-datashard-change-visibility branch from bd6507a to 706fae5 Compare January 16, 2024 13:33
@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision builded successful
Revision preview link

@snaury snaury marked this pull request as draft January 16, 2024 13:57
@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision builded successful
Revision preview link

@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blinkov blinkov blinkov approved these changes

@fomichev3000 fomichev3000 fomichev3000 left review comments

@kunga kunga kunga left review comments

@azevaykin azevaykin azevaykin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@snaury @blinkov @fomichev3000 @kunga @azevaykin