Sparsed columns are disabled by default and can be optionally enabled #9002
Conversation
|
⚪ ⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
ydb/core/kqp/ut/olap/sparsed_ut.cpp
Outdated
|
|
||
| TKikimrSettings GetKikimrSettings() { |
There was a problem hiding this comment.
нужно для всех тестов включить
| @@ -51,6 +52,14 @@ NKikimr::TConclusionStatus TStandaloneSchemaUpdate::DoInitializeImpl(const TUpda | |||
| } | |||
| } | |||
|
|
|||
| if (!AppData()->FeatureFlags.GetEnableSparsedColumns()) { | |||
There was a problem hiding this comment.
проверку, лучше, в TColumnTableUpdate добавить
✅ Documentation buildRevision built successfully |
c03e85c to
cd6f158
Compare
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
ydb/core/kqp/ut/olap/write_ut.cpp
Outdated
| @@ -133,6 +133,9 @@ Y_UNIT_TEST_SUITE(KqpOlapWrite) { | |||
|
|
|||
| Y_UNIT_TEST(DefaultValues) { | |||
| auto settings = TKikimrSettings().SetWithSampleTables(false); | |||
| NKikimrConfig::TFeatureFlags featureFlags; | |||
There was a problem hiding this comment.
перенеси, пожалуйста, инициацию флажка в конструктор TKikimrRunner
There was a problem hiding this comment.
Так я перенес, отсюда забыл убрать
There was a problem hiding this comment.
Лишний код тут убрал
ed229e1 to
9bd7a6b
Compare
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -97,6 +97,9 @@ struct TKikimrSettings: public TTestFeatureFlagsHolder<TKikimrSettings> { | |||
| exchangerSettings->SetStartDelayMs(10); | |||
| exchangerSettings->SetMaxDelayMs(10); | |||
| AppConfig.MutableColumnShardConfig()->SetDisabledOnSchemeShard(false); | |||
| NKikimrConfig::TFeatureFlags featureFlags; | |||
There was a problem hiding this comment.
а зачем мы все фичи перезаписываем? один флаг нельзя поменять?
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
…ydb-platform#9002) Conflicts: ydb/core/protos/feature_flags.proto
Changelog entry
...
Changelog category
Additional information
...