Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typed pg descriptor #8913

Merged
merged 8 commits into from
Sep 12, 2024
Merged

Typed pg descriptor #8913

merged 8 commits into from
Sep 12, 2024

Conversation

azevaykin
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@azevaykin azevaykin requested a review from a team as a code owner September 8, 2024 19:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 8, 2024 •
edited
Loading

⚪ 2024-09-08 19:18:13 UTC Pre-commit check linux-x86_64-release-clang14 for e4f663d has started.
⚪ 2024-09-08 19:21:25 UTC ya make is running...
🔴 2024-09-08 19:49:36 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 8, 2024 •
edited
Loading

⚪ 2024-09-08 19:18:13 UTC Pre-commit check linux-x86_64-release-asan for e4f663d has started.
⚪ 2024-09-08 19:21:30 UTC ya make is running...
🔴 2024-09-08 19:48:25 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 8, 2024 •
edited
Loading

⚪ 2024-09-08 19:18:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for e4f663d has started.
⚪ 2024-09-08 19:22:06 UTC ya make is running...
🔴 2024-09-08 19:53:36 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

⚪ 2024-09-09 06:06:40 UTC Pre-commit check linux-x86_64-release-asan for 0f71891 has started.
⚪ 2024-09-09 06:09:49 UTC ya make is running...
🔴 2024-09-09 08:02:13 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16035 15932 0 28 41 34

🟢 2024-09-09 08:03:36 UTC Build successful.
🟢 2024-09-09 08:04:10 UTC ydbd size 5.6 GiB changed* by +72 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: c0d60de merge: 0f71891 diff diff %
ydbd size 6 030 841 256 Bytes 6 030 841 328 Bytes +72 Bytes +0.000%
ydbd stripped size 1 510 004 848 Bytes 1 510 004 784 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

⚪ 2024-09-09 06:06:42 UTC Pre-commit check linux-x86_64-release-clang14 for 0f71891 has started.
⚪ 2024-09-09 06:09:50 UTC ya make is running...
🟢 2024-09-09 06:29:54 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

⚪ 2024-09-09 06:09:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0f71891 has started.
⚪ 2024-09-09 06:12:10 UTC ya make is running...
🟡 2024-09-09 07:33:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
78275 64445 0 39 13765 26

⚪ 2024-09-09 07:41:02 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-09 07:51:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74 (only retried tests) 28 0 28 0 18

⚪ 2024-09-09 07:51:12 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-09 07:58:31 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
51 (only retried tests) 26 0 7 0 18

🟢 2024-09-09 07:58:38 UTC Build successful.
🟢 2024-09-09 07:59:21 UTC ydbd size 8.4 GiB changed* by +152 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: c0d60de merge: 0f71891 diff diff %
ydbd size 9 015 196 936 Bytes 9 015 197 088 Bytes +152 Bytes +0.000%
ydbd stripped size 487 384 904 Bytes 487 384 904 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

alexd65536
alexd65536 previously approved these changes Sep 9, 2024
View reviewed changes
@azevaykin azevaykin force-pushed the ConstVoidTypeDesc branch 2 times, most recently from 2600b75 to 97046b7 Compare September 10, 2024 06:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

⚪ 2024-09-10 06:26:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 83797aa has started.
⚪ 2024-09-10 06:30:13 UTC ya make is running...
⚫ 2024-09-10 07:49:00 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

⚪ 2024-09-10 06:26:53 UTC Pre-commit check linux-x86_64-release-clang14 for 83797aa has started.
⚪ 2024-09-10 06:30:17 UTC ya make is running...
🟢 2024-09-10 07:34:01 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

⚪ 2024-09-10 06:26:53 UTC Pre-commit check linux-x86_64-release-asan for 83797aa has started.
⚪ 2024-09-10 06:30:18 UTC ya make is running...
⚫ 2024-09-10 07:48:36 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

⚪ 2024-09-10 07:52:11 UTC Pre-commit check linux-x86_64-release-clang14 for 0bbed50 has started.
⚪ 2024-09-10 07:55:54 UTC ya make is running...
🟢 2024-09-10 08:54:48 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

⚪ 2024-09-10 07:53:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0bbed50 has started.
⚪ 2024-09-10 07:56:40 UTC ya make is running...
🟡 2024-09-10 09:53:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
78739 64934 0 5 13777 23

⚪ 2024-09-10 10:01:22 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-10 10:09:20 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37 (only retried tests) 18 0 0 0 19

🟢 2024-09-10 10:09:26 UTC Build successful.
🟢 2024-09-10 10:10:12 UTC ydbd size 8.4 GiB changed* by +23.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: dd142f6 merge: 0bbed50 diff diff %
ydbd size 9 024 182 440 Bytes 9 024 206 384 Bytes +23.4 KiB +0.000%
ydbd stripped size 487 703 400 Bytes 487 704 936 Bytes +1.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

⚪ 2024-09-10 07:53:36 UTC Pre-commit check linux-x86_64-release-asan for 0bbed50 has started.
⚪ 2024-09-10 07:57:05 UTC ya make is running...
🔴 2024-09-10 10:41:16 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16502 16319 0 65 79 39

🟢 2024-09-10 10:42:45 UTC Build successful.
🟢 2024-09-10 10:45:33 UTC ydbd size 5.6 GiB changed* by +21.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: dd142f6 merge: 0bbed50 diff diff %
ydbd size 6 036 912 800 Bytes 6 036 934 432 Bytes +21.1 KiB +0.000%
ydbd stripped size 1 511 084 976 Bytes 1 511 095 504 Bytes +10.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin changed the title PgTypeDesc is const Typed pg descriptor Sep 10, 2024
vitstn
vitstn requested changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@vitstn vitstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

⚪ 2024-09-10 14:33:11 UTC Pre-commit check linux-x86_64-release-clang14 for 289879a has started.
⚪ 2024-09-10 14:33:20 UTC Artifacts will be uploaded here
⚪ 2024-09-10 14:36:26 UTC ya make is running...
🔴 2024-09-10 14:39:10 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

⚪ 2024-09-10 14:35:00 UTC Pre-commit check linux-x86_64-release-asan for 289879a has started.
⚪ 2024-09-10 14:35:13 UTC Artifacts will be uploaded here
⚪ 2024-09-10 14:38:14 UTC ya make is running...
🔴 2024-09-10 14:43:32 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 13:51:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2a9e720 has started.
⚪ 2024-09-11 13:52:37 UTC Artifacts will be uploaded here
⚪ 2024-09-11 13:56:25 UTC ya make is running...
🟡 2024-09-11 15:36:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
78588 64433 0 104 13785 266

⚪ 2024-09-11 15:44:08 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-11 15:55:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
382 (only retried tests) 201 0 84 7 90

⚪ 2024-09-11 15:55:50 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-11 16:06:54 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
179 (only retried tests) 14 0 77 0 88

🟢 2024-09-11 16:07:01 UTC Build successful.
🟢 2024-09-11 16:07:42 UTC ydbd size 8.4 GiB changed* by +43.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6e1d0a0 merge: 2a9e720 diff diff %
ydbd size 9 029 241 664 Bytes 9 029 286 432 Bytes +43.7 KiB +0.000%
ydbd stripped size 487 837 928 Bytes 487 838 824 Bytes +896 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 13:53:39 UTC Pre-commit check linux-x86_64-release-clang14 for 2a9e720 has started.
⚪ 2024-09-11 13:54:08 UTC Artifacts will be uploaded here
⚪ 2024-09-11 13:57:15 UTC ya make is running...
🟢 2024-09-11 14:34:32 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 13:58:07 UTC Pre-commit check linux-x86_64-release-asan for 2a9e720 has started.
⚪ 2024-09-11 13:58:48 UTC Artifacts will be uploaded here
⚪ 2024-09-11 14:02:34 UTC ya make is running...
🔴 2024-09-11 16:17:51 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16307 15860 0 110 64 273

🟢 2024-09-11 16:19:14 UTC Build successful.
🟢 2024-09-11 16:22:04 UTC ydbd size 5.6 GiB changed* by +6.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6e1d0a0 merge: 2a9e720 diff diff %
ydbd size 6 040 891 488 Bytes 6 040 897 584 Bytes +6.0 KiB +0.000%
ydbd stripped size 1 511 647 184 Bytes 1 511 649 168 Bytes +1.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 17:29:01 UTC Pre-commit check linux-x86_64-release-asan for 7cceeb0 has started.
⚪ 2024-09-11 17:29:35 UTC Artifacts will be uploaded here
⚪ 2024-09-11 17:33:08 UTC ya make is running...
🔴 2024-09-11 19:51:23 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16309 16104 0 36 61 108

🟢 2024-09-11 19:52:47 UTC Build successful.
🟢 2024-09-11 19:53:20 UTC ydbd size 5.6 GiB changed* by +5.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 409b154 merge: 7cceeb0 diff diff %
ydbd size 6 041 295 336 Bytes 6 041 300 512 Bytes +5.1 KiB +0.000%
ydbd stripped size 1 511 717 136 Bytes 1 511 718 672 Bytes +1.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 17:31:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7cceeb0 has started.
⚪ 2024-09-11 17:31:35 UTC Artifacts will be uploaded here
⚪ 2024-09-11 17:34:41 UTC ya make is running...
🟡 2024-09-11 19:16:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
78613 64509 0 13 14061 30

⚪ 2024-09-11 19:24:03 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-11 19:34:08 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
315 (only retried tests) 222 0 0 7 86

🟢 2024-09-11 19:34:17 UTC Build successful.
🟢 2024-09-11 19:35:01 UTC ydbd size 8.4 GiB changed* by +43.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 409b154 merge: 7cceeb0 diff diff %
ydbd size 9 029 726 088 Bytes 9 029 770 152 Bytes +43.0 KiB +0.000%
ydbd stripped size 487 854 184 Bytes 487 854 952 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

⚪ 2024-09-11 17:31:32 UTC Pre-commit check linux-x86_64-release-clang14 for 7cceeb0 has started.
⚪ 2024-09-11 17:31:41 UTC Artifacts will be uploaded here
⚪ 2024-09-11 17:34:47 UTC ya make is running...
🟢 2024-09-11 18:18:29 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 02:54:22 UTC Pre-commit check linux-x86_64-release-asan for 31e3b41 has started.
⚪ 2024-09-12 02:54:32 UTC Artifacts will be uploaded here
⚪ 2024-09-12 02:57:33 UTC ya make is running...
🔴 2024-09-12 04:52:05 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16308 15951 0 32 294 31

🟢 2024-09-12 04:53:28 UTC Build successful.
🟢 2024-09-12 04:54:01 UTC ydbd size 5.6 GiB changed* by +10.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9a9b2e6 merge: 31e3b41 diff diff %
ydbd size 6 044 822 040 Bytes 6 044 832 560 Bytes +10.3 KiB +0.000%
ydbd stripped size 1 512 777 904 Bytes 1 512 784 048 Bytes +6.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 02:54:32 UTC Pre-commit check linux-x86_64-release-clang14 for 31e3b41 has started.
⚪ 2024-09-12 02:54:43 UTC Artifacts will be uploaded here
⚪ 2024-09-12 02:57:49 UTC ya make is running...
🟢 2024-09-12 03:23:55 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

⚪ 2024-09-12 02:57:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 31e3b41 has started.
⚪ 2024-09-12 02:57:28 UTC Artifacts will be uploaded here
⚪ 2024-09-12 03:00:41 UTC ya make is running...
🟡 2024-09-12 04:36:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
78631 64567 0 9 14026 29

⚪ 2024-09-12 04:43:48 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-12 04:54:24 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
273 (only retried tests) 180 0 0 7 86

🟢 2024-09-12 04:54:33 UTC Build successful.
🟢 2024-09-12 04:55:11 UTC ydbd size 8.4 GiB changed* by +44.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9a9b2e6 merge: 31e3b41 diff diff %
ydbd size 9 034 978 992 Bytes 9 035 024 208 Bytes +44.2 KiB +0.001%
ydbd stripped size 488 200 168 Bytes 488 201 128 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin marked this pull request as ready for review September 12, 2024 11:26
@azevaykin azevaykin merged commit efdd4c7 into ydb-platform:main Sep 12, 2024
10 of 12 checks passed
@azevaykin azevaykin deleted the ConstVoidTypeDesc branch September 12, 2024 14:17
This was referenced Sep 13, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 17, 2024
Merged
This was referenced Sep 18, 2024
Merged
Merged
@shnikd shnikd mentioned this pull request Sep 19, 2024
Merged
azevaykin added a commit to azevaykin/ydb that referenced this pull request Nov 1, 2024
@azevaykin
Typed pg descriptor (ydb-platform#8913)
7adc2c0 
Strong typing of pg_wrapper functions

1. Add NKikimr::NScheme::ITypeDesc
2. Add NKikimr::NPg::ITypeDesc
3. They are casted using reinterpret_cast in ydb/core/scheme_types/scheme_type_info.h
azevaykin added a commit to azevaykin/ydb that referenced this pull request Dec 6, 2024
@azevaykin
Typed pg descriptor (ydb-platform#8913)
2963c0d 
Strong typing of pg_wrapper functions

1. Add NKikimr::NScheme::ITypeDesc
2. Add NKikimr::NPg::ITypeDesc
3. They are casted using reinterpret_cast in ydb/core/scheme_types/scheme_type_info.h
@zverevgeny zverevgeny mentioned this pull request Jan 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitstn vitstn vitstn approved these changes

@gridnevvvit gridnevvvit gridnevvvit approved these changes

@ildar-khisambeev ildar-khisambeev ildar-khisambeev approved these changes

@alexd65536 alexd65536 alexd65536 left review comments

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@azevaykin @vitstn @gridnevvvit @ildar-khisambeev @alexd65536