Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Date32 json serialization for column store #8848

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

fexolm
Copy link
Contributor

@fexolm fexolm commented Sep 6, 2024

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Additional information

...

@fexolm fexolm requested a review from a team as a code owner September 6, 2024 10:14
Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 10:15:48 UTC Pre-commit check linux-x86_64-release-asan for b5385fa has started.
2024-09-06 10:18:49 UTC ya make is running...
🔴 2024-09-06 12:20:17 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9900 9813 0 19 36 32

🟢 2024-09-06 12:21:11 UTC Build successful.
🟢 2024-09-06 12:21:40 UTC ydbd size 5.6 GiB changed* by +58.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0b897b9 merge: b5385fa diff diff %
ydbd size 6 028 914 536 Bytes 6 028 974 872 Bytes +58.9 KiB +0.001%
ydbd stripped size 1 509 645 488 Bytes 1 509 662 192 Bytes +16.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 10:16:04 UTC Pre-commit check linux-x86_64-release-clang14 for b5385fa has started.
2024-09-06 10:18:59 UTC ya make is running...
🟢 2024-09-06 11:02:06 UTC Build successful.

@fexolm fexolm requested a review from zverevgeny September 6, 2024 10:16
Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 10:17:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for b5385fa has started.
2024-09-06 10:20:15 UTC ya make is running...
🟡 2024-09-06 11:53:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14344 12952 0 3 1366 23

2024-09-06 11:54:47 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-06 12:04:14 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38 (only retried tests) 19 0 0 0 19

🟢 2024-09-06 12:04:21 UTC Build successful.
🟢 2024-09-06 12:04:59 UTC ydbd size 8.4 GiB changed* by +86.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0b897b9 merge: b5385fa diff diff %
ydbd size 9 013 279 192 Bytes 9 013 367 752 Bytes +86.5 KiB +0.001%
ydbd stripped size 487 289 416 Bytes 487 291 368 Bytes +1.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@fexolm fexolm requested a review from azevaykin September 6, 2024 10:21
@fexolm fexolm enabled auto-merge (squash) September 6, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants