-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resolved timestamp emitted too early for some displaced upserts #8847
Fix resolved timestamp emitted too early for some displaced upserts #8847
Conversation
6fa14ca
to
743b639
Compare
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Fix resolved timestamp emitted too early for some displaced upserts
Changelog category
Additional information
When an upsert is displaced (when current timestamp is blocked by a repeatable read) and shares timestamp with the next scheduled heartbeat, it was possible for that heartbeat to emit while we may still add more writes with that timestamp. The issue is fixed by using the correct comparison.
Found this bug while investigating #6985.